Revert "Add a flag to hostfxr_resolve_sdk2_flags_t to silence error messages" #120231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essages (dotnet#119729)" This reverts commit fc5252e.
jtschuster
requested review from
AaronRobinsonMSFT,
agocke,
Copilot and
elinor-fung
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previously added flag to the hostfxr API that was designed to silence error messages during SDK resolution. The revert is motivated by the SDK team reverting their telemetry change that originally necessitated this flag, making the API addition unnecessary.
- Removes the
do_not_print_errorsflag fromhostfxr_resolve_sdk2_flags_tenum - Simplifies the
hostfxr_resolve_sdk2function by removing the conditional error printing logic - Removes associated test cases that verified the error silencing functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/corehost/fxr/hostfxr.cpp | Removes the do_not_print_errors flag and simplifies SDK resolution logic |
| src/installer/tests/HostActivation.Tests/NativeHostApis.cs | Removes test cases for the error silencing functionality |
| src/installer/tests/Assets/Projects/HostApiInvokerApp/HostFXR.cs | Removes the flag definition from the test helper enum |
| docs/design/features/hosting-layer-apis.md | Updates documentation to remove the flag from the API specification |
AaronRobinsonMSFT
approved these changes
Sep 29, 2025
elinor-fung
approved these changes
Sep 29, 2025
This was referenced Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fc5252e (#119729). It isn't necessary after sdk reverted the telemetry change, and it adds unnecessarily to the API. The best workaround for similar functionality would be to use
hostfxr_set_error_writerto swallow the messages before the call tohostfxr_resolve_sdk2.