Skip to content

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Sep 29, 2025

Backport of #108582 to release/8.0

/cc @pavelsavara

Customer Impact

  • Customer reported
  • Found internally

Cleanup backport, tell mode. It affects only tests that used to fail infrequently on net8. We don't have them running on main for some time already. Fixes #111753.

Regression

  • Yes
  • No

Testing

CI.

Risk

Low, it's adjusting the set supported scenarios in the tests to match main's set.

@ilonatommy ilonatommy requested a review from radical as a code owner September 29, 2025 12:54
@Copilot Copilot AI review requested due to automatic review settings September 29, 2025 12:54
@ilonatommy ilonatommy added the arch-wasm WebAssembly architecture label Sep 29, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Node.js testing support for WebAssembly in the .NET 8.0 release branch, aligning test scenarios with the main branch. This is a cleanup backport that affects only tests that used to fail infrequently on net8.

Key Changes:

  • Removes Node.js host runner and test configurations
  • Updates test archive paths from "browserornodejs" to "browseronly"
  • Removes entire Blazor_net50 test asset directory

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/mono/wasm/testassets/Blazor_net50/* Complete removal of Blazor .NET 5.0 test assets
src/mono/wasm/features.md Removes Node.js-specific documentation and shell environment references
src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs Removes top-level args test method
src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs Complete removal of Node.js host runner implementation
src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs Removes NodeJS enum value and updates All flag
src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs Removes NodeJS case from host runner factory
src/libraries/*/tests/*.csproj Updates test archive paths from "browserornodejs" to "browseronly"
src/libraries/Common/tests/System/Net/Prerequisites/* Removes Node.js-specific TLS and middleware configurations
eng/testing/tests.browser.targets Removes Node.js NPM module setup commands
eng/testing/WasmRunnerTemplate.* Removes Node.js-specific engine arguments and configurations
eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml Removes Node.js testing scenarios and threading tests

Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@PranavSenthilnathan
Copy link
Member

Reminder that PRs into release/8.0-staging need to be completed by 4pm Redmond time on October 13 to make it into the November servicing release. After that point you'll need to target release/8.0 if you want to make the November release.

@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 13, 2025
@lewing
Copy link
Member

lewing commented Oct 13, 2025

this is a tell-mode test infrastructure only change.

@lewing lewing enabled auto-merge (squash) October 13, 2025 20:50
@ilonatommy ilonatommy closed this Oct 14, 2025
auto-merge was automatically disabled October 14, 2025 06:18

Pull request was closed

@ilonatommy ilonatommy reopened this Oct 14, 2025
@ilonatommy ilonatommy merged commit 12250f6 into release/8.0-staging Oct 14, 2025
127 checks passed
@lewing lewing deleted the backport/pr-108582-to-release/8.0 branch October 14, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasm WebAssembly architecture Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants