-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/8.0] Stop testing with nodejs #120195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Stop testing with nodejs #120195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes Node.js testing support for WebAssembly in the .NET 8.0 release branch, aligning test scenarios with the main branch. This is a cleanup backport that affects only tests that used to fail infrequently on net8.
Key Changes:
- Removes Node.js host runner and test configurations
- Updates test archive paths from "browserornodejs" to "browseronly"
- Removes entire Blazor_net50 test asset directory
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/mono/wasm/testassets/Blazor_net50/* |
Complete removal of Blazor .NET 5.0 test assets |
src/mono/wasm/features.md |
Removes Node.js-specific documentation and shell environment references |
src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs |
Removes top-level args test method |
src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs |
Complete removal of Node.js host runner implementation |
src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs |
Removes NodeJS enum value and updates All flag |
src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs |
Removes NodeJS case from host runner factory |
src/libraries/*/tests/*.csproj |
Updates test archive paths from "browserornodejs" to "browseronly" |
src/libraries/Common/tests/System/Net/Prerequisites/* |
Removes Node.js-specific TLS and middleware configurations |
eng/testing/tests.browser.targets |
Removes Node.js NPM module setup commands |
eng/testing/WasmRunnerTemplate.* |
Removes Node.js-specific engine arguments and configurations |
eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml |
Removes Node.js testing scenarios and threading tests |
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Reminder that PRs into release/8.0-staging need to be completed by 4pm Redmond time on October 13 to make it into the November servicing release. After that point you'll need to target release/8.0 if you want to make the November release. |
this is a tell-mode test infrastructure only change. |
Backport of #108582 to release/8.0
/cc @pavelsavara
Customer Impact
Cleanup backport, tell mode. It affects only tests that used to fail infrequently on net8. We don't have them running on main for some time already. Fixes #111753.
Regression
Testing
CI.
Risk
Low, it's adjusting the set supported scenarios in the tests to match main's set.