Skip to content

Fix DispatchProxy Generator Issues with AssemblyLoadContexts #120157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix DispatchProxy Generator Issues with AssemblyLoadContexts #120157

wants to merge 1 commit into from

Conversation

afifi-ins
Copy link

@afifi-ins afifi-ins commented Sep 26, 2025 •
edited
Loading

This PR fixes two scenarios where DispatchProxy behaves incorrectly when working with multiple AssemblyLoadContexts (ALCs).
Fixes:

  1. Corrects proxy generation where the second ALC could produce a proxy bound to the wrong interface type, leading to InvalidCastException.
  2. Fixes the case of creating a proxy when the base proxyType is in a non-collectable ALC (in this case the default ALC) and the interface is in a collectable ALC.

Added Unit test to prevent regressions.

Fixes: #109398

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 26, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 26, 2025
@afifi-ins afifi-ins force-pushed the DispatchProxyGeneraotor branch from f77dbf4 to eb9aeaf Compare September 26, 2025 20:56
@jkotas jkotas added area-System.Reflection and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 26, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

teo-tsirpanis
teo-tsirpanis reviewed Sep 27, 2025
View reviewed changes
@afifi-ins afifi-ins force-pushed the DispatchProxyGeneraotor branch from eb9aeaf to 8423f21 Compare September 29, 2025 05:02
@afifi-ins afifi-ins closed this Sep 29, 2025
@afifi-ins afifi-ins deleted the DispatchProxyGeneraotor branch September 29, 2025 16:55
@afifi-ins afifi-ins restored the DispatchProxyGeneraotor branch September 29, 2025 16:56
@afifi-ins afifi-ins reopened this Sep 29, 2025
This was referenced Sep 29, 2025
Open
Open
Open
@jkotas jkotas mentioned this pull request Sep 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

1 more reviewer

@teo-tsirpanis teo-tsirpanis teo-tsirpanis left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area-System.Reflection community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DispatchProxy generates a proxy type implementing the interface from the wrong ALC

3 participants

@afifi-ins @teo-tsirpanis @jkotas