-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[interp] Fix a minor bug #120140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[interp] Fix a minor bug #120140
Conversation
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
|
@janvorli Are you planning to support the ARM32 interpreter in the future? If it's possible, I'd like to contribute to the ARM32 support. (I am working on https://github.com/clamp03/runtime/tree/intrp_arm branch now.) |
For foreseeable future, we are planning to support and ship the interpreter on Apple devices and Wasm only. We do not have plans beyond that. I think we will be happy to accept fixes to make interpreter work on Arm32, but the interpreter support won't be included in Microsoft official builds. Why are you interested in the interpreter for Arm32? |
I think the interpreter is good for improving launch time and memory usage in some cases. For launch time, I tried to remove JIT compilation during app launch time by using Crossgen2 as much as possible. For memory, some methods like clinit and others are used only once in applications. I think we don't need to compile these all methods. I think executing some of them by interpreter is better than JITC and Crossgen2. Actually, we found huge clinit methods in our applications, so it takes very long time (to compile and run) and consumes much memory. We gave some guides for that, but it is still very large even though they fixed. In javascript engine, I got better launch time (around 10%) in the real applications (not benchmark) with the interpreter. So I want to check coreclr interpreter. (*. I expect the gain is less than javascript because they have different language features such as type. However, I think it is worth researching it.) I am going to contribute arm32 interpreter after long holiday in Korea. |
|
cc @dotnet/samsung |
|
Pushed a new PR as a draft in #120688 including this PR. |
I am working interpreter on arm32 based on arm64 iterpreter.
I found a bug in callstubgenerator when there are multiple pending ranges.
It occurs on arm32. However, I think it can be a problem in other archs.
(If I misunderstood, please let me know.)
Test case on arm32