Copy`dotnet.d.ts` to `wwwroot` on build/publish. #120097

ilonatommy · 2025-09-25T15:43:19Z

Fixes #77174.

src/mono/browser/build/BrowserWasmApp.targets

src/mono/browser/runtime/rollup.config.js

JakeYallop · 2025-09-25T20:24:59Z

Its also worth pointing that dotnet.d.ts is currently explicitly removed from the build via:

_WasmBuildFilesToRemove:

runtime/src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets

Line 279 in 7ab1ed3

Which is an output from the ComputeWasmBuildAssets task, in that task:

runtime/src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmBuildAssets.cs

Line 93 in 7ab1ed3

    
           if (AssetsComputingHelper.ShouldFilterCandidate(candidate, TimeZoneSupport, InvariantGlobalization, LoadFullICUData, CopySymbols, customIcuCandidateFilename, EnableThreads, EnableDiagnostics, EmitSourceMap, out var reason))

runtime/src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs

Line 74 in 7ab1ed3

    
           ".ts" when fromMonoPackage && fileName == "dotnet.d" => "dotnet type definition is not used by Blazor",

src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs

...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets

src/mono/wasm/build/WasmApp.Common.targets

src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs

src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmBuildAssets.cs

src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmPublishAssets.cs

src/mono/wasm/Wasm.Build.Tests/BrowserStructures/MSBuildOptions.cs

src/mono/wasm/build/WasmApp.Common.targets

…o fix-77174

Copilot

Pull Request Overview

Adds an opt-in MSBuild property to copy the generated dotnet.d.ts TypeScript definition file into a WebAssembly project's wwwroot during build, addressing issue #77174.

Introduces WasmEmitTypeScriptDefinitions property (default false) in relevant .targets.
Adds MSBuild target _EnsureDotnetTypeScriptDefinitions to perform the conditional copy.
Adds a test validating the file copy on build (Debug/Release).

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
src/mono/wasm/build/WasmApp.Common.targets	Documents and defines the new WasmEmitTypeScriptDefinitions property.
src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets	Adds property default again and new target to copy dotnet.d.ts into wwwroot.
src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs	Adds test ensuring dotnet.d.ts is copied on build when the property is enabled.

Copilot · 2025-10-03T16:03:13Z

src/mono/wasm/build/WasmApp.Common.targets

    <WasmStripILAfterAOT Condition="'$(WasmStripILAfterAOT)' == ''">true</WasmStripILAfterAOT>
    <WasmRuntimeAssetsLocation Condition="'$(WasmRuntimeAssetsLocation)' == ''">_framework</WasmRuntimeAssetsLocation>
    <MetricsSupport Condition="'$(MetricsSupport)' == ''">false</MetricsSupport>
+    <WasmEmitTypeScriptDefinitions Condition="'$(WasmEmitTypeScriptDefinitions)' == ''">false</WasmEmitTypeScriptDefinitions>


The default for WasmEmitTypeScriptDefinitions is also being set in Microsoft.NET.Sdk.WebAssembly.Browser.targets, creating duplicate sources of truth that can drift; consider centralizing the default in a single imported location (or guard one with Condition="'$(WasmEmitTypeScriptDefinitions)'=='' and '$(DefiningFileFlag)'!='true'") to avoid divergence.

Suggested change

<WasmEmitTypeScriptDefinitions Condition="'$(WasmEmitTypeScriptDefinitions)' == ''">false</WasmEmitTypeScriptDefinitions>

<WasmEmitTypeScriptDefinitions Condition="'$(WasmEmitTypeScriptDefinitions)' == '' and '$(DefiningFileFlag)' != 'true'">false</WasmEmitTypeScriptDefinitions>

Copilot · 2025-10-03T16:03:13Z

...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets

      <_WasmCopyOutputSymbolsToOutputDirectory Condition="'$(_WasmCopyOutputSymbolsToOutputDirectory)'==''">true</_WasmCopyOutputSymbolsToOutputDirectory>
      <_WasmEnableThreads>$(WasmEnableThreads)</_WasmEnableThreads>
      <_WasmEnableThreads Condition="'$(_WasmEnableThreads)' == ''">false</_WasmEnableThreads>
+      <WasmEmitTypeScriptDefinitions Condition="'$(WasmEmitTypeScriptDefinitions)' == ''">false</WasmEmitTypeScriptDefinitions>


This repeats the default assignment also added in WasmApp.Common.targets; please consolidate the default definition to one place to prevent future inconsistencies.

Suggested change

<WasmEmitTypeScriptDefinitions Condition="'$(WasmEmitTypeScriptDefinitions)' == ''">false</WasmEmitTypeScriptDefinitions>

Copilot · 2025-10-03T16:03:14Z

...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets

+      <_RuntimePackDir Condition="'$(_RuntimePackDir)' == ''">%(ResolvedRuntimePack.PackageDirectory)</_RuntimePackDir>
+      <_RuntimePackNativeDir>$([MSBuild]::NormalizeDirectory($(_RuntimePackDir), 'runtimes', 'browser-wasm', 'native'))</_RuntimePackNativeDir>
+      <_DotnetTypesSourcePath>$(_RuntimePackNativeDir)dotnet.d.ts</_DotnetTypesSourcePath>
+      <_DotnetTypesDestPath>$(MSBuildProjectDirectory)\wwwroot\dotnet.d.ts</_DotnetTypesDestPath>


[nitpick] Hardcoded backslashes reduce clarity on non-Windows; prefer a normalized construction such as $([MSBuild]::NormalizeDirectory('$(MSBuildProjectDirectory)','wwwroot'))dotnet.d.ts or $(MSBuildProjectDirectory)$(DirectorySeparatorChar)wwwroot$(DirectorySeparatorChar)dotnet.d.ts for cross-platform consistency.

Suggested change

<_DotnetTypesDestPath>$(MSBuildProjectDirectory)\wwwroot\dotnet.d.ts</_DotnetTypesDestPath>

<_DotnetTypesDestPath>$(MSBuildProjectDirectory)$(DirectorySeparatorChar)wwwroot$(DirectorySeparatorChar)dotnet.d.ts</_DotnetTypesDestPath>

Copilot · 2025-10-03T16:03:14Z

src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs

+            // Verify dotnet.d.ts is not in wwwroot after creation
+            Assert.False(File.Exists(dotnetDtsWwwrootPath), $"dotnet.d.ts should not exist at {dotnetDtsWwwrootPath} after creation when WasmEmitTypeScriptDefinitions is used");
+
+            // Build to trigger the _EnsureDotnetTypeScriptDefinitions target on restore


The comment is misleading—_EnsureDotnetTypeScriptDefinitions runs AfterTargets _ResolveWasmConfiguration during build, not restore; update the comment to reflect it triggers during the build phase.

Suggested change

// Build to trigger the _EnsureDotnetTypeScriptDefinitions target on restore

// Build to trigger the _EnsureDotnetTypeScriptDefinitions target during the build phase

maraf · 2025-10-04T15:55:35Z

src/mono/wasm/build/WasmApp.Common.targets

    <WasmStripILAfterAOT Condition="'$(WasmStripILAfterAOT)' == ''">true</WasmStripILAfterAOT>
    <WasmRuntimeAssetsLocation Condition="'$(WasmRuntimeAssetsLocation)' == ''">_framework</WasmRuntimeAssetsLocation>
    <MetricsSupport Condition="'$(MetricsSupport)' == ''">false</MetricsSupport>
+    <WasmEmitTypeScriptDefinitions Condition="'$(WasmEmitTypeScriptDefinitions)' == ''">false</WasmEmitTypeScriptDefinitions>


Suggested change

<WasmEmitTypeScriptDefinitions Condition="'$(WasmEmitTypeScriptDefinitions)' == ''">false</WasmEmitTypeScriptDefinitions>

There is no need to set the property here as well

maraf · 2025-10-04T15:57:48Z

...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets

+      <_RuntimePackNativeDir>$([MSBuild]::NormalizeDirectory($(_RuntimePackDir), 'runtimes', 'browser-wasm', 'native'))</_RuntimePackNativeDir>
+      <_DotnetTypesSourcePath>$(_RuntimePackNativeDir)dotnet.d.ts</_DotnetTypesSourcePath>


Suggested change

<_RuntimePackNativeDir>$([MSBuild]::NormalizeDirectory($(_RuntimePackDir), 'runtimes', 'browser-wasm', 'native'))</_RuntimePackNativeDir>

<_DotnetTypesSourcePath>$(_RuntimePackNativeDir)dotnet.d.ts</_DotnetTypesSourcePath>

<_DotnetTypesSourcePath>$([MSBuild]::NormalizeDirectory($(_RuntimePackDir), 'runtimes', 'browser-wasm', 'native', 'dotnet.d.ts'))</_DotnetTypesSourcePath>

maraf · 2025-10-04T15:58:39Z

...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets

      <_WasmCopyOutputSymbolsToOutputDirectory Condition="'$(_WasmCopyOutputSymbolsToOutputDirectory)'==''">true</_WasmCopyOutputSymbolsToOutputDirectory>
      <_WasmEnableThreads>$(WasmEnableThreads)</_WasmEnableThreads>
      <_WasmEnableThreads Condition="'$(_WasmEnableThreads)' == ''">false</_WasmEnableThreads>
+      <WasmEmitTypeScriptDefinitions Condition="'$(WasmEmitTypeScriptDefinitions)' == ''">false</WasmEmitTypeScriptDefinitions>


Please, follow the pattern with assign to private property first, and then set the default value to the private property

maraf · 2025-10-04T16:01:07Z

src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs

+        [Theory]
+        [InlineData(Configuration.Debug)]
+        [InlineData(Configuration.Release)]
+        public void TypeScriptDefinitionsCopiedToWwwrootOnBuild(Configuration config)


Please add a test case for false resulting in file not exist

Copydotnet.d.ts to wwwroot on build/publish.

3726dac

ilonatommy self-assigned this Sep 25, 2025

ilonatommy added arch-wasm WebAssembly architecture area-Build-mono labels Sep 25, 2025

maraf reviewed Sep 25, 2025

View reviewed changes

src/mono/browser/build/BrowserWasmApp.targets Outdated Show resolved Hide resolved

pavelsavara reviewed Sep 25, 2025

View reviewed changes

src/mono/browser/runtime/rollup.config.js Outdated Show resolved Hide resolved

ilonatommy added 2 commits September 29, 2025 17:28

Apply feedback.

47d35fb

Remove whitespace changes.

d34e93a

ilonatommy commented Sep 29, 2025

View reviewed changes

src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs Outdated Show resolved Hide resolved

maraf reviewed Sep 29, 2025

View reviewed changes

...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request Sep 29, 2025

Unable to pull image from mcr.microsoft.com #117164

Open

Fix expected files in WBT.

f799d78

Almost fixed.

330210b

ilonatommy commented Oct 1, 2025

View reviewed changes

...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets Outdated Show resolved Hide resolved

Fix test expectations.

077f47c

maraf reviewed Oct 1, 2025

View reviewed changes

src/mono/wasm/build/WasmApp.Common.targets Show resolved Hide resolved

maraf reviewed Oct 1, 2025

View reviewed changes

ilonatommy added 2 commits October 1, 2025 13:20

Cleanup + feedback.

b5ebda9

Misplaced.

b1d83d3

ilonatommy commented Oct 1, 2025

View reviewed changes

src/mono/wasm/build/WasmApp.Common.targets Outdated Show resolved Hide resolved

ilonatommy and others added 4 commits October 1, 2025 13:24

Correct docs.

ae3b3f0

Missing change for wbt.

bf23da1

Merge branch 'fix-77174' of https://github.com/ilonatommy/runtime int…

29a52b4

…o fix-77174

Move _EnsureDotnetTypeScriptDefinitions execution for a bit later.

da2355f

ilonatommy marked this pull request as ready for review October 3, 2025 16:01

ilonatommy requested review from lewing and akoeplinger as code owners October 3, 2025 16:01

Copilot AI review requested due to automatic review settings October 3, 2025 16:01

Copilot AI reviewed Oct 3, 2025

View reviewed changes

build-analysis bot mentioned this pull request Oct 3, 2025

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

maraf reviewed Oct 4, 2025

View reviewed changes

	<WasmEmitTypeScriptDefinitions Condition="'$(WasmEmitTypeScriptDefinitions)' == ''">false</WasmEmitTypeScriptDefinitions>
	<WasmEmitTypeScriptDefinitions Condition="'$(WasmEmitTypeScriptDefinitions)' == '' and '$(DefiningFileFlag)' != 'true'">false</WasmEmitTypeScriptDefinitions>

	<_DotnetTypesDestPath>$(MSBuildProjectDirectory)\wwwroot\dotnet.d.ts</_DotnetTypesDestPath>
	<_DotnetTypesDestPath>$(MSBuildProjectDirectory)$(DirectorySeparatorChar)wwwroot$(DirectorySeparatorChar)dotnet.d.ts</_DotnetTypesDestPath>

	// Build to trigger the _EnsureDotnetTypeScriptDefinitions target on restore
	// Build to trigger the _EnsureDotnetTypeScriptDefinitions target during the build phase

		<_RuntimePackNativeDir>$([MSBuild]::NormalizeDirectory($(_RuntimePackDir), 'runtimes', 'browser-wasm', 'native'))</_RuntimePackNativeDir>
		<_DotnetTypesSourcePath>$(_RuntimePackNativeDir)dotnet.d.ts</_DotnetTypesSourcePath>

	<_RuntimePackNativeDir>$([MSBuild]::NormalizeDirectory($(_RuntimePackDir), 'runtimes', 'browser-wasm', 'native'))</_RuntimePackNativeDir>
	<_DotnetTypesSourcePath>$(_RuntimePackNativeDir)dotnet.d.ts</_DotnetTypesSourcePath>
	<_DotnetTypesSourcePath>$([MSBuild]::NormalizeDirectory($(_RuntimePackDir), 'runtimes', 'browser-wasm', 'native', 'dotnet.d.ts'))</_DotnetTypesSourcePath>

Copydotnet.d.ts to wwwroot on build/publish. #120097

Are you sure you want to change the base?

Copydotnet.d.ts to wwwroot on build/publish. #120097

Uh oh!

Conversation

ilonatommy commented Sep 25, 2025

Uh oh!

Uh oh!

Uh oh!

JakeYallop commented Sep 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

maraf Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

maraf Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

maraf Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

maraf Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copy`dotnet.d.ts` to `wwwroot` on build/publish. #120097

Copy`dotnet.d.ts` to `wwwroot` on build/publish. #120097