[release/10.0] [RuntimeAsync] A few fixes for issues found when enabling rt async in Libraries. #119960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit de8c967.
VSadov
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
Tagging subscribers to this area: @mangod9 |
|
@AndyAyersMS - could you take a look at this backport PR? |
kg
reviewed
Sep 22, 2025
kg
reviewed
Sep 22, 2025
|
I don't see anything fatal, so seems fine. |
|
Adding @davidwrighton for VM review. |
|
Thanks!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119864 to release/10.0
/cc @VSadov
Customer Impact
Customer reported
Found internally
In async methods the GS cookie check, if also present, could end up using (and corrupting) the same register as used to return continuation.
Synthetic async thunks that provide interop between ordinary task-returning methods and runtime async methods, did not special-case
ValueTask, which is sufficiently different to require slightly different IL.When multiple awaits are in the same try block, the async analysis could pay attention only to the first one and skip over others.
These bugs require fairly trivial fixes, but otherwise could result in crashes in affected scenarios.
Regression
This is new code/scenarios with runtime async.
Testing
The fix was verified on existing libraries tests that caught the issues.
Risk
Low, most changes are to the new code that is only enabled with runtime async.