[release/10.0] [mono] Actually free dynamic methods, even if we have profiler attached #119950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ever since the early days of mono, freeing dynamic methods was disabled if a profiler was attached. The reason for this was probably that the profiler might store `MonoMethod` instances in its own data, leading to problems if we free those instances. Looking at the profilers nowadays it is not clear where patterns like this would happen. Profilers that do store methods (like aot, coverage), don't process wrapper methods, so we should be safe since dynamic methods have the MONO_WRAPPER_DYNAMIC_METHOD wrapper type. The problem is that, nowadays, we can always have a profiler attached even if no actual profiling happens. macios for example always calls mono_profiler_install. I belive actual callbacks can be added later as necessary.
github-actions
bot
requested review from
steveisok,
thaystg and
vitek-karas
as code owners
|
I believe it would make more sense to backport this together with fixes on the interpreter side that add freeing of interpreter data. I need to do some more investigations on that front so this will miss RC2. |
|
Tagging subscribers to this area: @steveisok, @vitek-karas |
rbhanda
added
Servicing-approved
|
@steveisok This PR was a draft. I needed to add a couple more commits to it so it is complete. Closed it so no confusions happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119749 to release/10.0
/cc @BrzVlad
Customer Impact
Dynamic methods leak even after they are collected / no longer used.
Regression
Testing
This was tested on applications making use of system reflection emit.
Risk
Low. This just frees various runtime data that is no longer used.