Skip to content
Merged
Changes from 5 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System.Collections.Immutable;
using System.Reflection.Metadata;
using System.Reflection.Metadata.Ecma335;
using System.Runtime.CompilerServices;

namespace System.Reflection.Emit
{
Expand Down Expand Up @@ -223,12 +224,67 @@ private static void WriteSignatureForType(SignatureTypeEncoder signature, Type t
{
signature.GenericTypeParameter(type.GenericParameterPosition);
}
else if (type.IsFunctionPointer)
{
WriteSignatureForFunctionPointerType(signature, type, module);
}
else
{
WriteSimpleSignature(signature, type, module);
}
}

private static void WriteSignatureForFunctionPointerType(SignatureTypeEncoder signature, Type type, ModuleBuilderImpl module)
{
SignatureCallingConvention callConv = SignatureCallingConvention.Default;
FunctionPointerAttributes attribs = FunctionPointerAttributes.None;
List<Type> retModOpts = [.. type.GetFunctionPointerReturnType().GetOptionalCustomModifiers()];

if (type.GetFunctionPointerCallingConventions() is Type[] conventions && conventions.Length > 0)
{
foreach (Type conv in conventions)
{
if (conv == typeof(CallConvCdecl))
callConv = SignatureCallingConvention.CDecl;
else if (conv == typeof(CallConvStdcall))
callConv = SignatureCallingConvention.StdCall;
else if (conv == typeof(CallConvThiscall))
callConv = SignatureCallingConvention.ThisCall;
else if (conv == typeof(CallConvFastcall))
callConv = SignatureCallingConvention.FastCall;
else
retModOpts.Add(conv);
}
}

MethodSignatureEncoder sigEncoder = signature.FunctionPointer(callConv, attribs);
sigEncoder.Parameters(type.GetFunctionPointerParameterTypes().Length, out ReturnTypeEncoder retTypeEncoder, out ParametersEncoder paramsEncoder);

CustomModifiersEncoder retModifiersEncoder = retTypeEncoder.CustomModifiers();

if (retModOpts.Count > 0)
WriteCustomModifiers(retModifiersEncoder, [.. retModOpts], isOptional: true, module);

if (type.GetFunctionPointerReturnType().GetRequiredCustomModifiers() is Type[] retModReqs)
WriteCustomModifiers(retModifiersEncoder, retModReqs, isOptional: false, module);

WriteSignatureForType(retTypeEncoder.Type(), type.GetFunctionPointerReturnType(), module);

foreach (Type paramType in type.GetFunctionPointerParameterTypes())
{
ParameterTypeEncoder paramEncoder = paramsEncoder.AddParameter();
CustomModifiersEncoder paramModifiersEncoder = paramEncoder.CustomModifiers();

if (paramType.GetOptionalCustomModifiers() is Type[] paramModOpts)
WriteCustomModifiers(paramModifiersEncoder, paramModOpts, isOptional: true, module);

if (paramType.GetRequiredCustomModifiers() is Type[] paramModReqs)
WriteCustomModifiers(paramModifiersEncoder, paramModReqs, isOptional: false, module);

WriteSignatureForType(paramEncoder.Type(), paramType, module);
}
}

private static void WriteSimpleSignature(SignatureTypeEncoder signature, Type type, ModuleBuilderImpl module)
{
CoreTypeId? typeId = module.GetTypeIdFromCoreTypes(type);
Expand Down
Loading