Skip to content

Conversation

PranavSenthilnathan
Copy link
Member

@PranavSenthilnathan PranavSenthilnathan commented Sep 19, 2025

Backport of #117010. These are the runtime changes to migrate to WiX 5. This includes updating the WiX 3 source files to WiX 5 in addition to UI and localization updates. It also sets the flag telling arcade dependencies to use WiX 5 instead of WiX 3.

WiX 3 is out of support so we need to move to WiX 5 to ensure we get the latest security updates going forward.

Customer Impact

No expected impact.

Regression

  • Yes
  • No

Testing

Manually validated by CTI team.

Risk

Medium. This could introduce new issues, but we need to move to WiX 5 so it's better to find and fix bugs in RC2 rather than in GA.

Co-authored-by: Nikola Milosavljevic <[email protected]>
@PranavSenthilnathan PranavSenthilnathan added this to the 10.0.0 milestone Sep 19, 2025
@PranavSenthilnathan PranavSenthilnathan self-assigned this Sep 19, 2025
@Copilot Copilot AI review requested due to automatic review settings September 19, 2025 08:35
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 19, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the .NET runtime installer infrastructure from WiX 4 to WiX 5, which is required for continued MSI generation support. The migration updates package references, configuration files, and localizable content to use the new WiX 5 schema and APIs.

Key changes include:

  • Update WiX package references to version 5.0.2
  • Migrate WiX XML schemas from v4 to v5 namespaces
  • Convert localization files from XML content to value attributes

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
eng/Versions.props Adds WiX 5 package version definitions
src/installer/pkg/sfx//Directory.Build. Configures WiX 5 usage and package references
src/installer/pkg/sfx/installers/host.wxs Updates WiX schema and improves component structure
src/installer/pkg/sfx/bundle/bundle.thm Modernizes theme file with WiX 5 schema and improved accessibility
src/installer/pkg/sfx/bundle/theme/*/bundle.wxl Converts localization format from XML content to value attributes

@PranavSenthilnathan PranavSenthilnathan added area-Infrastructure-installer and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 19, 2025
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

Copy link
Member

@joeloff joeloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the localization builds to make sure the new content is available to the vendors. There's a parser change required (already in Arcade).

@PranavSenthilnathan
Copy link
Member Author

Please check the localization builds to make sure the new content is available to the vendors. There's a parser change required (already in Arcade).

There was an automated check-in to the wxl files, so I'm assuming everything is set up correctly:
https://github.com/dotnet/runtime/commits/main/src/installer/pkg/sfx/bundle/theme/1028/bundle.wxl

I don't think that's set up for release/10.0, but we can backport the translations if not.

@PranavSenthilnathan PranavSenthilnathan added the Servicing-approved Approved for servicing release label Sep 19, 2025
@jozkee jozkee merged commit 8ca6013 into dotnet:release/10.0 Sep 19, 2025
165 of 170 checks passed
@github-project-automation github-project-automation bot moved this to Done in Wix5 Sep 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants