Skip to content

Conversation

steveisok
Copy link
Member

No description provided.

@steveisok steveisok requested review from a team and Copilot September 17, 2025 16:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the macOS Helix queue versions from OSX 12 to OSX 13 for both ARM64 and x64 architectures in the release/8.0 branch. This change affects build infrastructure configuration for running tests and builds on macOS platforms.

Key Changes:

  • Updates macOS Helix queue references from OSX.1200 (macOS 12) to OSX.13 (macOS 13)
  • Applies changes to both ARM64 and x64 architectures
  • Updates both library and CoreCLR pipeline configurations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/pipelines/libraries/helix-queues-setup.yml Updates macOS queue versions for library testing pipelines
eng/pipelines/coreclr/templates/helix-queues-setup.yml Updates macOS queue versions for CoreCLR testing pipelines including both public and internal project configurations

@akoeplinger
Copy link
Member

this will need the openssl test disabling from #112647

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@steveisok steveisok added the Servicing-approved Approved for servicing release label Sep 18, 2025
@steveisok
Copy link
Member Author

This is an infra only change

@akoeplinger
Copy link
Member

@steveisok the failures here look related

@steveisok
Copy link
Member Author

@dotnet/runtime-infrastructure can I get a review on this?

Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only question is if we want to remove the msquic infra - devs might use it to test changes in the library for validation. Otherwise lgtm

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll be building on this soon to add OSX.26 coverage too, so thank you for pushing this forward, @steveisok.

@steveisok
Copy link
Member Author

steveisok commented Sep 30, 2025

Weird, only osx mono crashes on this NotSupported test because it's expecting / not-expecting openssl

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.OpenSslNotPresentOnSystem))]
public static void NotSupported()
{
Assert.Throws<PlatformNotSupportedException>(() => SafeEvpPKeyHandle.OpenPublicKeyFromEngine(TestEngineName, TestEngineKeyId));
Assert.Throws<PlatformNotSupportedException>(() => SafeEvpPKeyHandle.OpenPrivateKeyFromEngine(TestEngineName, TestEngineKeyId));
}
I'm just going to skip it outright.

@steveisok steveisok merged commit 24e4b41 into dotnet:release/8.0-staging Oct 2, 2025
187 of 189 checks passed
@steveisok steveisok deleted the bump-mac-queues-8 branch October 2, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Infrastructure Servicing-approved Approved for servicing release

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants