-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/8.0] Bump OSX.12 helix queues to OSX.13 #119815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Bump OSX.12 helix queues to OSX.13 #119815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the macOS Helix queue versions from OSX 12 to OSX 13 for both ARM64 and x64 architectures in the release/8.0 branch. This change affects build infrastructure configuration for running tests and builds on macOS platforms.
Key Changes:
- Updates macOS Helix queue references from OSX.1200 (macOS 12) to OSX.13 (macOS 13)
- Applies changes to both ARM64 and x64 architectures
- Updates both library and CoreCLR pipeline configurations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
eng/pipelines/libraries/helix-queues-setup.yml | Updates macOS queue versions for library testing pipelines |
eng/pipelines/coreclr/templates/helix-queues-setup.yml | Updates macOS queue versions for CoreCLR testing pipelines including both public and internal project configurations |
this will need the openssl test disabling from #112647 |
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
This is an infra only change |
@steveisok the failures here look related |
@dotnet/runtime-infrastructure can I get a review on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only question is if we want to remove the msquic infra - devs might use it to test changes in the library for validation. Otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'll be building on this soon to add OSX.26 coverage too, so thank you for pushing this forward, @steveisok.
Weird, only osx mono crashes on this runtime/src/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs Lines 58 to 63 in fda25cd
|
24e4b41
into
dotnet:release/8.0-staging
No description provided.