Skip to content

Name boolean arguments in StreamReader ctors #119802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

Name boolean arguments in StreamReader ctors #119802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/libraries/System.Private.CoreLib/src/System/IO/StreamReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,22 +101,22 @@ private StreamReader()
}

public StreamReader(Stream stream)
: this(stream, true)
: this(stream, detectEncodingFromByteOrderMarks: true)
{
}

public StreamReader(Stream stream, bool detectEncodingFromByteOrderMarks)
: this(stream, Encoding.UTF8, detectEncodingFromByteOrderMarks, DefaultBufferSize, false)
: this(stream, Encoding.UTF8, detectEncodingFromByteOrderMarks, DefaultBufferSize, leaveOpen: false)
{
}

public StreamReader(Stream stream, Encoding? encoding)
: this(stream, encoding, true, DefaultBufferSize, false)
: this(stream, encoding, detectEncodingFromByteOrderMarks: true, DefaultBufferSize, leaveOpen: false)
{
}

public StreamReader(Stream stream, Encoding? encoding, bool detectEncodingFromByteOrderMarks)
: this(stream, encoding, detectEncodingFromByteOrderMarks, DefaultBufferSize, false)
: this(stream, encoding, detectEncodingFromByteOrderMarks, DefaultBufferSize, leaveOpen: false)
{
}

Expand All @@ -131,7 +131,7 @@ public StreamReader(Stream stream, Encoding? encoding, bool detectEncodingFromBy
// of those three match, it will use the Encoding you provided.
//
public StreamReader(Stream stream, Encoding? encoding, bool detectEncodingFromByteOrderMarks, int bufferSize)
: this(stream, encoding, detectEncodingFromByteOrderMarks, bufferSize, false)
: this(stream, encoding, detectEncodingFromByteOrderMarks, bufferSize, leaveOpen: false)
{
}

Expand Down Expand Up @@ -177,7 +177,7 @@ public StreamReader(Stream stream, Encoding? encoding = null, bool detectEncodin
}

public StreamReader(string path)
: this(path, true)
: this(path, detectEncodingFromByteOrderMarks: true)
{
}

Expand All @@ -187,7 +187,7 @@ public StreamReader(string path, bool detectEncodingFromByteOrderMarks)
}

public StreamReader(string path, Encoding? encoding)
: this(path, encoding, true, DefaultBufferSize)
: this(path, encoding, detectEncodingFromByteOrderMarks: true, DefaultBufferSize)
{
}

Expand All @@ -202,7 +202,7 @@ public StreamReader(string path, Encoding? encoding, bool detectEncodingFromByte
}

public StreamReader(string path, FileStreamOptions options)
: this(path, Encoding.UTF8, true, options)
: this(path, Encoding.UTF8, detectEncodingFromByteOrderMarks: true, options)
{
}

Expand Down
Loading