[release/10.0] Set IDE0031 to suggestion in eng/CodeAnalysis.src.globalconfig #119755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the severity level of IDE0031 (Use null propagation) from warning to suggestion in the CodeAnalysis configuration to address a Roslyn bug that causes inconsistent build behavior across different machines.
- Changes IDE0031 analyzer severity from warning to suggestion to prevent build breaks
- Addresses a Roslyn bug where .editorconfig settings incorrectly override globalconfig settings on some machines only
- Provides a low-risk alternative to backporting the full fix from the original PR
github-actions
bot
added
the
needs-area-label
Member
Author
|
Build-only change required to fix build breaks, tell mode, applying Servicing-approved. |
akoeplinger
added
Servicing-approved
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
sbomer
approved these changes
Sep 16, 2025
Member
|
Merging. Infrastructure fix required for clean builds |
Member
|
Thanks @akoeplinger! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution for the backport of #119722
Instead of backporting fixing the IDE0031 which is a quite large change we just turn the severity into
suggestion.Customer Impact
There's a Roslyn bug where the
suggestionseverity fordotnet_style_null_propagationin .editorconfig incorrectly overrides the IDE0031warningseverity set in eng/CodeAnalysis.src.globalconfig on some machines only (root cause is currently being investigated in dotnet/roslyn#80301).This causes build breaks on machines where this doesn't happen and the IDE0031 warning severity is active.
Regression
Testing
The CI build verifies this works.
Risk
Low. This just turns an analyzer code style finding from warning to suggestion.