Skip to content

Simplify null checks to fix IDE0031 #119722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 16, 2025
Merged

Simplify null checks to fix IDE0031 #119722

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6fa9f81
Use null-coalescing operator in LocalDataFlowState.cs
akoeplinger Sep 15, 2025
06be5b6
Copilot feedback
akoeplinger Sep 15, 2025
2df2d47
Revert Copilot feedback
akoeplinger Sep 15, 2025
d87af8e
Fix IDE0031 analyzer findings
akoeplinger Sep 15, 2025
6dac8bb
Don't set severity for dotnet_style_null_propagation
akoeplinger Sep 15, 2025
3fb4ac6
Fix more IDE0031
akoeplinger Sep 15, 2025
81bf036
Fix more IDE0031
akoeplinger Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/tools/illink/src/ILLink.RoslynAnalyzer/DataFlow/LocalDataFlowState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,8 @@ public LocalStateAndContext<TValue, TContext> Current
public void Set(LocalKey key, TValue value)
{
current.LocalState.Set(key, value);
if (Exception != null)
// TODO: optimize this to not meet the whole value, but just modify one value without copying.
Exception.Value = Lattice.Meet(Exception.Value, current);
// TODO: optimize this to not meet the whole value, but just modify one value without copying.
Exception?.Value = Lattice.Meet(Exception.Value, current);
}

public TValue Get(LocalKey key) => current.LocalState.Get(key);
Expand Down