[mono][metadata] Enable compressed interface bitmap by default #119694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
BrzVlad
force-pushed
the
feature-compressed-interface-bitmap
branch
from
180637e to
48e02a5
Compare
Before this commit we were doing changes on the published data which is problematic for multithreaded environments. We ensure the bitmap is fully processed before publishing it so that we can rely on the data dependency memory ordering constraint for correctness.
BrzVlad
force-pushed
the
feature-compressed-interface-bitmap
branch
from
48e02a5 to
b62f455
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables the compressed interface bitmap feature by default in the Mono runtime. This optimization compresses the interface bitmap used for interface type checking, reducing memory usage.
Key changes:
- Remove the
MONO_SMALL_CONFIGconditional compilation guard for compressed interface bitmap - Add explicit type casting to avoid compiler warnings
- Improve variable naming for clarity
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mono/mono/metadata/class-internals.h | Removes conditional compilation guard, enabling compressed interface bitmap by default |
| src/mono/mono/metadata/class-setup-vtable.c | Improves variable naming and adds type cast for offset parameter |
| src/mono/mono/metadata/class-init.c | Adds explicit uint8_t casts to prevent potential compiler warnings |
| src/mono/mono/mini/type-checking.c | Adds explicit type cast for offset parameter to target_mgreg_t |
|
I assume the idea is to enable compressed bitmaps on all platforms to measure perf impact and then decide on additional actions, like if it should be default on just some platforms, if it should be a dynamic option or not etc. If so, I think we should also create a tracking issue and link it to this PR describing the different work items, where this is the first step. |
lateralusX
approved these changes
Sep 15, 2025
There was a problem hiding this comment.
The wide impact of the change, default on all platforms, is mainly to measure overhead. This will be followed up with additional changes based on perf data to either limit change to a set of platforms and/or add ability to enable/disable interface map compression dynamically (aot/runtime arguments). I also think we should link a tracking issue to this PR since it is one work item in a set of work items to resolve the underlying issue.
|
/ba-g wasm build tests known failure |
BrzVlad
added a commit
to BrzVlad/runtime
that referenced
this pull request
Sep 17, 2025
…t#119694) * [mono][metadata] Enable compressed interface bitmap by default * Fix build on windows * Fix publishing of compressed bitmap Before this commit we were doing changes on the published data which is problematic for multithreaded environments. We ensure the bitmap is fully processed before publishing it so that we can rely on the data dependency memory ordering constraint for correctness.
BrzVlad
added a commit
to BrzVlad/runtime
that referenced
this pull request
Sep 22, 2025
…t#119694) * [mono][metadata] Enable compressed interface bitmap by default * Fix build on windows * Fix publishing of compressed bitmap Before this commit we were doing changes on the published data which is problematic for multithreaded environments. We ensure the bitmap is fully processed before publishing it so that we can rely on the data dependency memory ordering constraint for correctness.
agocke
pushed a commit
that referenced
this pull request
Sep 22, 2025
…able (#119953) * [mono][metadata] Enable compressed interface bitmap by default (#119694) * [mono][metadata] Enable compressed interface bitmap by default * Fix build on windows * Fix publishing of compressed bitmap Before this commit we were doing changes on the published data which is problematic for multithreaded environments. We ensure the bitmap is fully processed before publishing it so that we can rely on the data dependency memory ordering constraint for correctness. * [mono] Enable configuration at runtime of the compressed interface bitmap feature (#119881) * Add option to configure use of compressed interface bitmaps This optimization is disabled by default. Enable it with `MONO_COMPRESSED_INTERFACE_BITMAP=1` * Add support for detecting mismatch with aot images
BrzVlad
added a commit
to BrzVlad/runtime
that referenced
this pull request
Sep 23, 2025
…t#119694) * [mono][metadata] Enable compressed interface bitmap by default * Fix build on windows * Fix publishing of compressed bitmap Before this commit we were doing changes on the published data which is problematic for multithreaded environments. We ensure the bitmap is fully processed before publishing it so that we can rely on the data dependency memory ordering constraint for correctness.
BrzVlad
added a commit
to BrzVlad/runtime
that referenced
this pull request
Sep 26, 2025
…t#119694) * [mono][metadata] Enable compressed interface bitmap by default * Fix build on windows * Fix publishing of compressed bitmap Before this commit we were doing changes on the published data which is problematic for multithreaded environments. We ensure the bitmap is fully processed before publishing it so that we can rely on the data dependency memory ordering constraint for correctness.
steveisok
pushed a commit
that referenced
this pull request
Oct 1, 2025
…ble (#120154) * [mono][metadata] Enable compressed interface bitmap by default (#119694) * [mono][metadata] Enable compressed interface bitmap by default * Fix build on windows * Fix publishing of compressed bitmap Before this commit we were doing changes on the published data which is problematic for multithreaded environments. We ensure the bitmap is fully processed before publishing it so that we can rely on the data dependency memory ordering constraint for correctness. * [mono] Enable configuration at runtime of the compressed interface bitmap feature (#119881) * Add option to configure use of compressed interface bitmaps This optimization is disabled by default. Enable it with `MONO_COMPRESSED_INTERFACE_BITMAP=1` * Add support for detecting mismatch with aot images
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.