Skip to content

[browser] corehost for browser #119683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[browser] corehost for browser #119683

wants to merge 6 commits into from
+432 −38

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Sep 13, 2025 •
edited
Loading

  • draft of src\native\corehost\browser\
    • to statically link: coreclr_static, Browser.Native-Static, System.Native-Static, System.Globalization.Native-Static, System.IO.Compression.Native-Static
    • implement pinvoke_override for static libraries above.
    • this makes native dependencies not trimmable based on IL trimming.
  • draft of src\native\libs\Browser.Native\
    • just a stub
  • rename mono_wasm_browser_entropy to BrowserNative_RandomBytes
  • do not link ICU data into System.Globalization.Native for browser
  • add CLR+browser subsets

Limitations

  • this is targeting NodeJS for now
  • this doesn't bring any of the necessary TypeScript/loader+interop code
  • pinvoke for statically linked 3rd party native libraries and for trimming. It will need generator.

@pavelsavara pavelsavara added this to the 11.0.0 milestone Sep 13, 2025
@pavelsavara pavelsavara self-assigned this Sep 13, 2025
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Host os-browser Browser variant of arch-wasm labels Sep 13, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

SingleAccretion
SingleAccretion reviewed Sep 13, 2025
View reviewed changes
@pavelsavara
Copy link
Member Author

Together with #119591

image

This was referenced Sep 13, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewing lewing Awaiting requested review from lewing lewing will be requested when the pull request is marked ready for review lewing is a code owner

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad will be requested when the pull request is marked ready for review BrzVlad is a code owner

@janvorli janvorli Awaiting requested review from janvorli janvorli will be requested when the pull request is marked ready for review janvorli is a code owner

@kg kg Awaiting requested review from kg kg will be requested when the pull request is marked ready for review kg is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

1 more reviewer

@SingleAccretion SingleAccretion SingleAccretion left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Host os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @SingleAccretion