Skip to content

HMAC Verify #119652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Sep 17, 2025
Merged

HMAC Verify #119652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
8c33ee5
Add one-shots for HMAC.Verify
vcsjones Sep 10, 2025
129175d
Add Stream Verify to HMACSHA1
vcsjones Sep 10, 2025
d14ba7a
Add synchronous streams for other HMAC algorithms
vcsjones Sep 10, 2025
7b910df
Zero mac when we are done with it
vcsjones Sep 10, 2025
5481d8e
Add VerifyAsync to SHA-1
vcsjones Sep 11, 2025
96af7e2
Expand VerifyAsync to all HMAC classes
vcsjones Sep 11, 2025
f4d520a
Add tests
vcsjones Sep 11, 2025
68a1088
Deduplicate Verify and VerifyAsync
vcsjones Sep 11, 2025
b5134f1
Remove redundant namespace qualification
vcsjones Sep 11, 2025
b7e7ce5
Document SHA-3 PNSE consistently
vcsjones Sep 11, 2025
ad802c7
Add Verify to IncrementalHash
vcsjones Sep 11, 2025
355353e
Doc formatting fixes
vcsjones Sep 11, 2025
503e907
Add CO.VerifyHmac
vcsjones Sep 11, 2025
c08a3bb
Add Verify(Stream) and other misc. cleanup
vcsjones Sep 12, 2025
91b6d93
Round off CryptographicOperations.
vcsjones Sep 12, 2025
2b2f073
Code review feedback
vcsjones Sep 12, 2025
7afda60
Add missing test for reset
vcsjones Sep 15, 2025
a0130aa
Add missing API docs
vcsjones Sep 15, 2025
c19303b
Rename HMACShared to HMACStatic
vcsjones Sep 16, 2025
d2aa57b
Finish rename
vcsjones Sep 16, 2025
9e75f23
Change to stackalloc only since the hash set is closed and known
vcsjones Sep 16, 2025
ff4f4b0
Fix async return docs
vcsjones Sep 17, 2025
cb6409e
Fix SHA1 / SHA-1
vcsjones Sep 17, 2025
da2ba3f
Test async correctly
vcsjones Sep 17, 2025
f90bee7
Use explicit collection types
vcsjones Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,12 @@ public static partial class CryptographicOperations
public static System.Threading.Tasks.ValueTask<byte[]> HmacDataAsync(System.Security.Cryptography.HashAlgorithmName hashAlgorithm, System.ReadOnlyMemory<byte> key, System.IO.Stream source, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static bool TryHashData(System.Security.Cryptography.HashAlgorithmName hashAlgorithm, System.ReadOnlySpan<byte> source, System.Span<byte> destination, out int bytesWritten) { throw null; }
public static bool TryHmacData(System.Security.Cryptography.HashAlgorithmName hashAlgorithm, System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.Span<byte> destination, out int bytesWritten) { throw null; }
public static bool VerifyHmac(System.Security.Cryptography.HashAlgorithmName hashAlgorithm, byte[] key, byte[] source, byte[] hash) { throw null; }
public static bool VerifyHmac(System.Security.Cryptography.HashAlgorithmName hashAlgorithm, byte[] key, System.IO.Stream source, byte[] hash) { throw null; }
public static bool VerifyHmac(System.Security.Cryptography.HashAlgorithmName hashAlgorithm, System.ReadOnlySpan<byte> key, System.IO.Stream source, System.ReadOnlySpan<byte> hash) { throw null; }
public static bool VerifyHmac(System.Security.Cryptography.HashAlgorithmName hashAlgorithm, System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.ReadOnlySpan<byte> hash) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyHmacAsync(System.Security.Cryptography.HashAlgorithmName hashAlgorithm, byte[] key, System.IO.Stream source, byte[] hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyHmacAsync(System.Security.Cryptography.HashAlgorithmName hashAlgorithm, System.ReadOnlyMemory<byte> key, System.IO.Stream source, System.ReadOnlyMemory<byte> hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static void ZeroMemory(System.Span<byte> buffer) { }
}
public partial class CryptographicUnexpectedOperationException : System.Security.Cryptography.CryptographicException
Expand Down Expand Up @@ -1548,6 +1554,18 @@ public override void Initialize() { }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public static bool TryHashData(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.Span<byte> destination, out int bytesWritten) { throw null; }
protected override bool TryHashFinal(System.Span<byte> destination, out int bytesWritten) { throw null; }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public static bool Verify(byte[] key, byte[] source, byte[] hash) { throw null; }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public static bool Verify(byte[] key, System.IO.Stream source, byte[] hash) { throw null; }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public static bool Verify(System.ReadOnlySpan<byte> key, System.IO.Stream source, System.ReadOnlySpan<byte> hash) { throw null; }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public static bool Verify(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.ReadOnlySpan<byte> hash) { throw null; }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(byte[] key, System.IO.Stream source, byte[] hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(System.ReadOnlyMemory<byte> key, System.IO.Stream source, System.ReadOnlyMemory<byte> hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
}
public partial class HMACSHA1 : System.Security.Cryptography.HMAC
{
Expand Down Expand Up @@ -1575,6 +1593,12 @@ protected override void HashCore(System.ReadOnlySpan<byte> source) { }
public override void Initialize() { }
public static bool TryHashData(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.Span<byte> destination, out int bytesWritten) { throw null; }
protected override bool TryHashFinal(System.Span<byte> destination, out int bytesWritten) { throw null; }
public static bool Verify(byte[] key, byte[] source, byte[] hash) { throw null; }
public static bool Verify(byte[] key, System.IO.Stream source, byte[] hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.IO.Stream source, System.ReadOnlySpan<byte> hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.ReadOnlySpan<byte> hash) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(byte[] key, System.IO.Stream source, byte[] hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(System.ReadOnlyMemory<byte> key, System.IO.Stream source, System.ReadOnlyMemory<byte> hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
}
public partial class HMACSHA256 : System.Security.Cryptography.HMAC
{
Expand All @@ -1599,6 +1623,12 @@ protected override void HashCore(System.ReadOnlySpan<byte> source) { }
public override void Initialize() { }
public static bool TryHashData(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.Span<byte> destination, out int bytesWritten) { throw null; }
protected override bool TryHashFinal(System.Span<byte> destination, out int bytesWritten) { throw null; }
public static bool Verify(byte[] key, byte[] source, byte[] hash) { throw null; }
public static bool Verify(byte[] key, System.IO.Stream source, byte[] hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.IO.Stream source, System.ReadOnlySpan<byte> hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.ReadOnlySpan<byte> hash) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(byte[] key, System.IO.Stream source, byte[] hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(System.ReadOnlyMemory<byte> key, System.IO.Stream source, System.ReadOnlyMemory<byte> hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
}
public partial class HMACSHA384 : System.Security.Cryptography.HMAC
{
Expand All @@ -1625,6 +1655,12 @@ protected override void HashCore(System.ReadOnlySpan<byte> source) { }
public override void Initialize() { }
public static bool TryHashData(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.Span<byte> destination, out int bytesWritten) { throw null; }
protected override bool TryHashFinal(System.Span<byte> destination, out int bytesWritten) { throw null; }
public static bool Verify(byte[] key, byte[] source, byte[] hash) { throw null; }
public static bool Verify(byte[] key, System.IO.Stream source, byte[] hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.IO.Stream source, System.ReadOnlySpan<byte> hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.ReadOnlySpan<byte> hash) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(byte[] key, System.IO.Stream source, byte[] hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(System.ReadOnlyMemory<byte> key, System.IO.Stream source, System.ReadOnlyMemory<byte> hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
}
public partial class HMACSHA3_256 : System.Security.Cryptography.HMAC
{
Expand All @@ -1650,6 +1686,12 @@ protected override void HashCore(System.ReadOnlySpan<byte> source) { }
public override void Initialize() { }
public static bool TryHashData(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.Span<byte> destination, out int bytesWritten) { throw null; }
protected override bool TryHashFinal(System.Span<byte> destination, out int bytesWritten) { throw null; }
public static bool Verify(byte[] key, byte[] source, byte[] hash) { throw null; }
public static bool Verify(byte[] key, System.IO.Stream source, byte[] hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.IO.Stream source, System.ReadOnlySpan<byte> hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.ReadOnlySpan<byte> hash) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(byte[] key, System.IO.Stream source, byte[] hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(System.ReadOnlyMemory<byte> key, System.IO.Stream source, System.ReadOnlyMemory<byte> hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
}
public partial class HMACSHA3_384 : System.Security.Cryptography.HMAC
{
Expand All @@ -1675,6 +1717,12 @@ protected override void HashCore(System.ReadOnlySpan<byte> source) { }
public override void Initialize() { }
public static bool TryHashData(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.Span<byte> destination, out int bytesWritten) { throw null; }
protected override bool TryHashFinal(System.Span<byte> destination, out int bytesWritten) { throw null; }
public static bool Verify(byte[] key, byte[] source, byte[] hash) { throw null; }
public static bool Verify(byte[] key, System.IO.Stream source, byte[] hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.IO.Stream source, System.ReadOnlySpan<byte> hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.ReadOnlySpan<byte> hash) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(byte[] key, System.IO.Stream source, byte[] hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(System.ReadOnlyMemory<byte> key, System.IO.Stream source, System.ReadOnlyMemory<byte> hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
}
public partial class HMACSHA3_512 : System.Security.Cryptography.HMAC
{
Expand All @@ -1700,6 +1748,12 @@ protected override void HashCore(System.ReadOnlySpan<byte> source) { }
public override void Initialize() { }
public static bool TryHashData(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.Span<byte> destination, out int bytesWritten) { throw null; }
protected override bool TryHashFinal(System.Span<byte> destination, out int bytesWritten) { throw null; }
public static bool Verify(byte[] key, byte[] source, byte[] hash) { throw null; }
public static bool Verify(byte[] key, System.IO.Stream source, byte[] hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.IO.Stream source, System.ReadOnlySpan<byte> hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.ReadOnlySpan<byte> hash) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(byte[] key, System.IO.Stream source, byte[] hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(System.ReadOnlyMemory<byte> key, System.IO.Stream source, System.ReadOnlyMemory<byte> hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
}
public partial class HMACSHA512 : System.Security.Cryptography.HMAC
{
Expand All @@ -1726,6 +1780,12 @@ protected override void HashCore(System.ReadOnlySpan<byte> source) { }
public override void Initialize() { }
public static bool TryHashData(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.Span<byte> destination, out int bytesWritten) { throw null; }
protected override bool TryHashFinal(System.Span<byte> destination, out int bytesWritten) { throw null; }
public static bool Verify(byte[] key, byte[] source, byte[] hash) { throw null; }
public static bool Verify(byte[] key, System.IO.Stream source, byte[] hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.IO.Stream source, System.ReadOnlySpan<byte> hash) { throw null; }
public static bool Verify(System.ReadOnlySpan<byte> key, System.ReadOnlySpan<byte> source, System.ReadOnlySpan<byte> hash) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(byte[] key, System.IO.Stream source, byte[] hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static System.Threading.Tasks.ValueTask<bool> VerifyAsync(System.ReadOnlyMemory<byte> key, System.IO.Stream source, System.ReadOnlyMemory<byte> hash, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
}
public partial interface ICryptoTransform : System.IDisposable
{
Expand Down Expand Up @@ -1761,6 +1821,10 @@ public void Dispose() { }
public int GetHashAndReset(System.Span<byte> destination) { throw null; }
public bool TryGetCurrentHash(System.Span<byte> destination, out int bytesWritten) { throw null; }
public bool TryGetHashAndReset(System.Span<byte> destination, out int bytesWritten) { throw null; }
public bool VerifyCurrentHash(byte[] hash) { throw null; }
public bool VerifyCurrentHash(System.ReadOnlySpan<byte> hash) { throw null; }
public bool VerifyHashAndReset(byte[] hash) { throw null; }
public bool VerifyHashAndReset(System.ReadOnlySpan<byte> hash) { throw null; }
}
public abstract partial class KeyedHashAlgorithm : System.Security.Cryptography.HashAlgorithm
{
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Security.Cryptography/src/System.Security.Cryptography.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,7 @@
<Compile Include="System\Security\Cryptography\HMACSHA3_256.cs" />
<Compile Include="System\Security\Cryptography\HMACSHA3_384.cs" />
<Compile Include="System\Security\Cryptography\HMACSHA3_512.cs" />
<Compile Include="System\Security\Cryptography\HMACStatic.cs" />
<Compile Include="System\Security\Cryptography\ICryptoTransform.cs" />
<Compile Include="System\Security\Cryptography\ICspAsymmetricAlgorithm.cs" />
<Compile Include="System\Security\Cryptography\ILiteSymmetricCipher.cs" />
Expand Down
Loading
Loading