Skip to content

Conversation

Smaug123
Copy link
Contributor

The current documentation doesn't actually say what the semantics of the result are.

@Copilot Copilot AI review requested due to automatic review settings September 12, 2025 12:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the documentation for the PeriodicTimer.WaitForNextTickAsync method by clarifying the boolean return value semantics and the different completion states of the returned ValueTask.

Key Changes

  • Enhanced the XML documentation to explicitly describe when the method returns true vs false
  • Added clarification about the cancellation behavior and task state

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 12, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 12, 2025
@jkotas jkotas added area-System.Threading documentation Documentation bug or enhancement, does not impact product or test code and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 12, 2025
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Threading community-contribution Indicates that the PR has been added by a community member documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants