Skip to content

Removing conversion from typehandle to methodtable #119625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Removing conversion from typehandle to methodtable #119625

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a2a4c
removing conversion from typehandle to methodtable
rcj1 Sep 12, 2025
871b88b
update src/coreclr/debug/daccess/request.cpp
rcj1 Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/coreclr/debug/daccess/request.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1982,10 +1982,9 @@ ClrDataAccess::GetFieldDescData(CLRDATA_ADDRESS addr, struct DacpFieldDescData *
// drag in this data structure in minidump's case.
//
TypeHandle th = pFieldDesc->LookupFieldTypeHandle();
MethodTable *pMt = th.GetMethodTable();
if (pMt)
if (th.AsTAddr())
{
FieldDescData->MTOfType = HOST_CDADDR(th.GetMethodTable());
FieldDescData->MTOfType = HOST_CDADDR(PTR_MethodTable(th.AsTAddr()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FieldDescData->MTOfType = HOST_CDADDR(PTR_MethodTable(th.AsTAddr()));
FieldDescData->MTOfType = TO_CDADDR(th.AsTAddr());

Any reason to convert the TADDR to a pointer to convert it back to a TADDR?

}
else
{
Expand Down
Loading