[interp] Detect relocations pointing to invalid targets #119590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call badcode instead of asserting for certain types of invalid branches
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to detect relocations pointing to invalid targets in the CoreCLR interpreter compiler. The changes improve error handling by replacing assertions with proper error reporting when encountering invalid branch targets or offsets.
- Adds validation for relocation targets with invalid native offsets
- Replaces assertions with BADCODE error reporting for better diagnostics
- Ensures branch targets are properly validated before use
davidwrighton
approved these changes
Sep 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIT\jit64\verif\sniff\fg\ver_fg_13