Skip to content

Optimise bounds check in Replace.ReplaceComparer #119560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

Optimise bounds check in Replace.ReplaceComparer #119560

merged 1 commit into from
Oct 24, 2025

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Sep 11, 2025 •
edited
Loading

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 11, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 11, 2025
@xtqqczze xtqqczze mentioned this pull request Sep 11, 2025
Open
@MihuBot MihuBot mentioned this pull request Sep 11, 2025
Open
@xtqqczze xtqqczze mentioned this pull request Sep 12, 2025
Open
This was referenced Sep 12, 2025
Open
Open
@xtqqczze xtqqczze changed the title Optimize Replace.ReplaceComparer Optimise bounds check in Replace.ReplaceComparer Oct 2, 2025
@MihuBot MihuBot mentioned this pull request Oct 2, 2025
Open
@xtqqczze xtqqczze marked this pull request as draft October 2, 2025 14:37
@xtqqczze xtqqczze marked this pull request as ready for review October 2, 2025 14:55
@marek-safar marek-safar requested a review from a team October 6, 2025 06:48
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Oct 6, 2025

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

@teo-tsirpanis teo-tsirpanis removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 7, 2025
@tannergooding tannergooding merged commit 46a4004 into dotnet:main Oct 24, 2025
150 checks passed
@xtqqczze xtqqczze deleted the ReplaceComparer branch October 24, 2025 16:11
@dotnet-maestro dotnet-maestro bot mentioned this pull request Oct 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephentoub stephentoub stephentoub left review comments

@tannergooding tannergooding tannergooding approved these changes

+1 more reviewer

@hamarb123 hamarb123 hamarb123 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Memory community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xtqqczze @stephentoub @tannergooding @hamarb123 @marek-safar @teo-tsirpanis