Remove base DAM mismatch warning on types #119419
Draft
+366
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @dotnet/illink |
Moving this warning is more complicated than that for base types because we would either need to warn on conversion to interfaces, or warn on every constructor (for kept interface implementations).
sbomer
changed the title
- Move new constraint processing to generic dataflow - Take new constraint into account for requires dataflow check
MethodBodyScanner tracks known stacks by IL offset, so these need to be correct when analyzing IL. We can't just wait for cecil to update offsets for us when writing to disk.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118713 (analyzer only for now)
Depends on #119291