-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[wasm coreclr] Minor nits #119369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm coreclr] Minor nits #119369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables finalizer and stub precode heap functionality when targeting WebAssembly (WASM) to address runtime issues and simplify the WASM-specific code path. The changes ensure that WASM builds avoid unnecessary threading and heap management complexity.
- Disables the creation of
InterleavedLoaderHeap
for stub precode when portable entry points are used - Prevents finalizer thread enablement on WASM targets
- Reorganizes finalizer thread creation logic to clearly separate Windows, WASM, and other platform behaviors
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/coreclr/vm/loaderallocator.cpp | Guards new stub precode heap creation with FEATURE_PORTABLE_ENTRYPOINTS |
src/coreclr/vm/finalizerthread.cpp | Disables finalizer enablement for WASM targets |
src/coreclr/vm/ceemain.cpp | Restructures finalizer thread initialization logic with clearer platform-specific conditionals |
Tagging subscribers to this area: @mangod9 |
/ba-g CI failure unrelated |
Disable finalizer creation logic when targeting WASM.
Disable
EnableFinalizer
trigger method when targeting WASM.Disable new stub precode heap. This removes use of
InterleavedLoaderHeap
.Fixes #117501