Skip to content

[OSX] ip_mreqn struct is not supported for IPv4 Multicast #119354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 9, 2025
Merged

[OSX] ip_mreqn struct is not supported for IPv4 Multicast #119354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5cc12a8
Fix IPv4 multicast on macOS by handling ip_mreqn struct compatibility
liveans Sep 5, 2025
a408dd6
Remove Active Issue for iOS
liveans Sep 5, 2025
46c56f1
Add support for IP_MULTICAST_IFINDEX
liveans Sep 8, 2025
3be47f1
Refactor IPv4 multicast option handling to directly use IP_MULTICAST_…
liveans Sep 8, 2025
9089eb0
Accept 0 interface as valid
liveans Sep 8, 2025
dc68628
Merge branch 'main' into ipv4_multicast_osx_fix
wfurt Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ public void MulticastOption_CreateSocketSetGetOption_GroupAndInterfaceIndex_SetS
}

[ConditionalFact(nameof(CanRunMulticastTests))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/113827", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile))]
public async Task MulticastInterface_Set_AnyInterface_Succeeds()
{
// On all platforms, index 0 means "any interface"
Expand Down
1 change: 1 addition & 0 deletions src/native/libs/Common/pal_config.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
#cmakedefine01 HAVE_SUPPORT_FOR_DUAL_MODE_IPV4_PACKET_INFO
#cmakedefine01 HAVE_IN_PKTINFO
#cmakedefine01 HAVE_IP_MREQN
#cmakedefine01 HAVE_IP_MULTICAST_IFINDEX
#cmakedefine01 HAVE_NETINET_TCP_VAR_H
#cmakedefine01 HAVE_NETINET_UDP_VAR_H
#cmakedefine01 HAVE_NETINET_IP_VAR_H
Expand Down
11 changes: 11 additions & 0 deletions src/native/libs/System.Native/pal_networking.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1186,6 +1186,7 @@ int32_t SystemNative_GetIPv4MulticastOption(intptr_t socket, int32_t multicastOp
return Error_SUCCESS;
}


int32_t SystemNative_SetIPv4MulticastOption(intptr_t socket, int32_t multicastOption, IPv4MulticastOption* option)
{
if (option == NULL)
Expand All @@ -1201,6 +1202,16 @@ int32_t SystemNative_SetIPv4MulticastOption(intptr_t socket, int32_t multicastOp
return Error_EINVAL;
}

#if HAVE_IP_MULTICAST_IFINDEX
// Use IP_MULTICAST_IFINDEX when available for interface index specification
if (optionName == SocketOptionName_SO_IP_MULTICAST_IF)
{
uint32_t ifindex = (uint32_t)option->InterfaceIndex;
int err = setsockopt(fd, IPPROTO_IP, IP_MULTICAST_IFINDEX, &ifindex, sizeof(ifindex));
return err == 0 ? Error_SUCCESS : SystemNative_ConvertErrorPlatformToPal(errno);
}
#endif

#if HAVE_IP_MREQN
struct ip_mreqn opt;
memset(&opt, 0, sizeof(struct ip_mreqn));
Expand Down
12 changes: 12 additions & 0 deletions src/native/libs/configure.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,18 @@ check_c_source_compiles(
"
HAVE_IP_MREQN)

check_c_source_compiles(
"
#include <sys/socket.h>
#include <${SOCKET_INCLUDES}>
int main(void)
{
int opt = IP_MULTICAST_IFINDEX;
return 0;
}
"
HAVE_IP_MULTICAST_IFINDEX)

# /in_pktinfo

check_c_source_compiles(
Expand Down
Loading