[release/9.0-staging][maccatalyst] Check for -Wno-overriding-option for compatibility with clang in Xcode 16.3+ #119301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clang in Xcode 16.3+ (dotnet#119260) llvm/llvm-project@1c66d08 renamed the option `-Wno-overriding-t-option` to `-Wno-overriding-option`. This caused some configure time checks in CMake to fail because of hitting an unknown compiler option. (cherry picked from commit 4b8a478)
|
Infrastructure/build-only change necessary to build the runtime on newer macOS/Xcode versions, tell-mode, applying servicing-approved. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Mac Catalyst builds with newer Xcode versions (16.3+) by updating compiler flag compatibility checks. The issue occurs because clang renamed the -Wno-overriding-t-option flag to -Wno-overriding-option, causing CMake configure checks to fail with unknown compiler options.
Key changes:
- Removes hardcoded compiler flag that may not be supported in newer clang versions
- Adds runtime detection logic to test for both old and new compiler flag names
- Implements fallback mechanism with proper error handling for unsupported compilers
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mono/mono.proj | Removes hardcoded -Wno-overriding-t-option flag that breaks with newer clang |
| src/mono/CMakeLists.txt | Adds Mac Catalyst compiler flag detection with fallback support |
| eng/native/configurecompiler.cmake | Implements dynamic compiler flag detection and fixes typo in comment |
Comments suppressed due to low confidence (1)
eng/native/configurecompiler.cmake:669
- Fixed typo in comment: changed '-tagret' to '-target'.
# We need to disable the warning that -target replaces -mmacosx-version-min
Open
3 tasks
|
/ba-g wasm failure is not related to the changes which only apply to MacCatalyst |
ViktorHofer
approved these changes
Sep 4, 2025
akoeplinger
merged commit 89f3ed1
into
dotnet:release/9.0-staging
154 of 157 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119260 to release/9.0-staging
Customer Impact
This just affects the runtime build when using newer Xcode and caused some configure time checks in CMake to fail because of hitting an unknown compiler option, which breaks the build.
Regression
Testing
Building locally and on CI.
Risk
Low. This just adds additional checks to use the new name for the compiler option.