-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[WASI] Acquire the WASI SDK for runtime build automatically and centrally #119253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4d8647f
to
db7f5e2
Compare
Can be replaced with "-lstdc++", expanded to "-lc++" + "-lc++abi" by clang.
db7f5e2
to
c0bf4d8
Compare
Tagging subscribers to 'arch-wasm': @lewing |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
Well, the WASI build looks a bit better than before, but the AOT on Helix is having a hard time... Some instances of:
Some instances of clang OOMing. At least the WASI SDK was transported there properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me 👍
We are also building WASI SDK packages, longer term question is if should migrate to it. It can then be part of WASI workload.
@pavelsavara Please provide your feedback, as you have been working on WASI more closely.
I created #119299 for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better than what we had so far, many thanks!
I tested it locally on windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit, looks good otherwise
/ba-g CI failures are unrelated |
I was after a few things with this change:
All of these have been achieved with this change. See my inline comments for details.