[release/10.0] Add cast to ComAwareWeakReference rehydrate path #119141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents hard to diagnose crashes caused by COM interop rehydrating wrong type.
AaronRobinsonMSFT
approved these changes
Aug 27, 2025
AaronRobinsonMSFT
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Aug 27, 2025
jeffschwMSFT
added
Servicing-approved
|
fyi @jevansaks @manodasanW whenever this flows to you there's a chance it could catch other places where you may be returning an invalid value. |
|
Thanks for the heads up! Are you planning to bring it to net9 also? If it's just in net10 then we can watch out for it when we're migrating. |
|
We do not plan to bring this to net9. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119132 to release/10.0
/cc @jkotas
Customer Impact
This change makes it easier to diagnose COM interop (WinRT) bugs where it rehydrates wrong type. Before this change, this type of CsWinRT bug results into runtime crash that requires significant effort and good amount of luck to diagnose. After this change, the same CsWinRT bug produces InvalidCastException right when the issue occurs.
Regression
Testing
Standard regression pass
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.