Use unsized delete when we calculate size dynamically in a custom new overload #119112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #119099 by adding custom operator delete overloads that delegate to unsized delete operators in classes that use dynamically calculated sizes in their custom new operators. This ensures proper cleanup when objects are destroyed, avoiding potential undefined behavior from relying on sized delete with incorrect size values.
Key changes:
- Added custom sized
operator deleteoverloads that call unsized::operator delete - Applied this pattern consistently across three classes with dynamic size allocation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/coreclr/vm/virtualcallstub.h | Added sized delete operator to FastTable class that delegates to unsized delete |
| src/coreclr/vm/methodtable.h | Added sized delete operator to MethodDataObject class that delegates to unsized delete |
| src/coreclr/vm/crossloaderallocatorhash.h | Added sized delete operator to KeyValueStore class that delegates to unsized delete |
|
Tagging subscribers to this area: @mangod9 |
…lass as that's where the delete would route to.
Co-authored-by: Aaron Robinson <[email protected]>
Co-authored-by: Aaron Robinson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119099