Skip to content

[release/8.0-staging] make Http2_RequestFailsWithAppropriateHttpProtocolException test more deterministic #119103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: [manual] Merge release/8.0-staging into release/8.0
merged 2 commits into from
Aug 27, 2025
Merged

[release/8.0-staging] make Http2_RequestFailsWithAppropriateHttpProtocolException test more deterministic #119103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d3d180
make Http2_IncorrectServerPreface_RequestFailsWithAppropriateHttpProt…
wfurt Oct 27, 2023
16b0289
feedback
wfurt Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ public async Task Http2_StreamResetByServerBeforePrefix_RequestFailsWithGoawayPr

Http2LoopbackConnection connection = await server.AcceptConnectionAsync(timeout: null);
_ = await connection.ReadSettingsAsync();

// Wait until client starts sending request
_ = await connection.ReadFrameAsync(TestHelper.PassingTestTimeout);
GoAwayFrame goAwayFrame = new GoAwayFrame(lastStreamId: 0, (int)ProtocolErrors.HTTP_1_1_REQUIRED, additionalDebugData: Array.Empty<byte>(), streamId: 0);
await connection.WriteFrameAsync(goAwayFrame);

Expand Down Expand Up @@ -363,6 +364,8 @@ public async Task Http2_IncorrectServerPreface_RequestFailsWithAppropriateHttpPr

Http2LoopbackConnection connection = await server.AcceptConnectionAsync();
await connection.ReadSettingsAsync();
// Wait until client starts sending request
_ = await connection.ReadFrameAsync(TestHelper.PassingTestTimeout);
await connection.SendGoAway(0, ProtocolErrors.INTERNAL_ERROR);

await AssertProtocolErrorAsync(sendTask, ProtocolErrors.INTERNAL_ERROR);
Expand Down
Loading