[DAC] ClrDataAccess::StartEnumMethodInstancesByAddress return S_FALSE on failure #119021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the DAC (Data Access Component) implementation where ClrDataAccess::StartEnumMethodInstancesByAddress was incorrectly returning S_OK instead of S_FALSE when failing to get a method descriptor. The fix ensures consistent error handling behavior across both the native DAC implementation and the managed cDAC implementation.
Key changes:
- Fixed the native DAC implementation to return
S_FALSEwhenGetCodeMethodDescfails - Cleaned up redundant code in the managed cDAC implementation by consolidating initialization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/debug/daccess/daccess.cpp | Added missing S_FALSE assignment when GetCodeMethodDesc fails |
| src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs | Removed redundant S_OK initialization and duplicate S_FALSE assignment |
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs
Show resolved
Hide resolved
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
hoyosjs
approved these changes
Aug 22, 2025
This was referenced Aug 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a portion of this in #115131, but caused a failure of getting a methodDesc to return
S_OKinstead ofS_FALSE.Clean up cDAC implementation.