Use Guid(ReadOnlySpan<Byte>) ctor
#119010
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Guid` is not a blittable type, it requires special handling in the case of big-endian systems.
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
MihaZupan
reviewed
Aug 22, 2025
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Outdated
Show resolved
Hide resolved
xtqqczze
changed the title
Guid(ReadOnlySpan<Byte>) torGuid(ReadOnlySpan<Byte>) ctor
jkotas
reviewed
Aug 22, 2025
| byte* ptr = GetCurrentPointerAndAdvance(size); | ||
| byte* ptr = GetCurrentPointerAndAdvance(sizeof(Guid)); | ||
|
|
||
| #if NET |
There was a problem hiding this comment.
I do not think that this change is worth it. It is adding ifdef, it is not reducing amount of unsafe code, and it may make the code a bit slower.
This was referenced Aug 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.