[main] Source code updates from dotnet/dotnet #118914

dotnet-maestro · 2025-08-20T02:06:27Z

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Subscription: f7901f87-9f24-40d6-9bc1-564863937237
Build: 20250820.21
Date Produced: August 20, 2025 10:59:56 PM UTC
Commit: c4dc56079d959dbdb7fc27ea8ad7f95194885923
Commit Diff: 5c3434d...c4dc560
Branch: main

Updated Dependencies

From 5.0.0-2.25418.105 to 5.0.0-2.25420.121
- Microsoft.CodeAnalysis
- Microsoft.CodeAnalysis.Analyzers
- Microsoft.CodeAnalysis.CSharp
- Microsoft.Net.Compilers.Toolset
From 10.0.0-preview.25418.105 to 10.0.100-rc.1.25420.121
- Microsoft.CodeAnalysis.NetAnalyzers
From 10.0.100-rc.1.25418.105 to 10.0.100-rc.1.25420.121
- Microsoft.DotNet.ApiCompat.Task
- Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport
From 10.0.0-beta.25418.105 to 10.0.0-beta.25420.121
- Microsoft.DotNet.Arcade.Sdk
- Microsoft.DotNet.Build.Tasks.Archives
- Microsoft.DotNet.Build.Tasks.Feed
- Microsoft.DotNet.Build.Tasks.Installers
- Microsoft.DotNet.Build.Tasks.Packaging
- Microsoft.DotNet.Build.Tasks.TargetFramework
- Microsoft.DotNet.Build.Tasks.Templating
- Microsoft.DotNet.Build.Tasks.Workloads
- Microsoft.DotNet.CodeAnalysis
- Microsoft.DotNet.GenAPI
- Microsoft.DotNet.GenFacades
- Microsoft.DotNet.Helix.Sdk
- Microsoft.DotNet.PackageTesting
- Microsoft.DotNet.RemoteExecutor
- Microsoft.DotNet.SharedFramework.Sdk
- Microsoft.DotNet.XliffTasks
- Microsoft.DotNet.XUnitExtensions
From 0.11.5-alpha.25418.105 to 0.11.5-alpha.25420.121
- Microsoft.DotNet.Cecil
From 2.9.3-beta.25418.105 to 2.9.3-beta.25420.121
- Microsoft.DotNet.XUnitAssert
- Microsoft.DotNet.XUnitConsoleRunner
From 10.0.0-rc.1.25418.105 to 10.0.0-rc.1.25420.121
- Microsoft.NET.Sdk.IL
- Microsoft.NETCore.App.Ref
- Microsoft.NETCore.ILAsm
- runtime.native.System.IO.Ports
- System.Reflection.Metadata
- System.Reflection.MetadataLoadContext
- System.Text.Json
From 7.0.0-preview.1.41905 to 7.0.0-preview.1.42121
- NuGet.Frameworks
- NuGet.Packaging
- NuGet.ProjectModel
- NuGet.Versioning
From 2.0.0-rc.1.25418.105 to 2.0.0-rc.1.25420.121
- System.CommandLine

Associated changes in source repos

[[ commit created by automation ]]

Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25418.105 -> 5.0.0-2.25419.104) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25418.105 -> 10.0.100-rc.1.25419.104) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-rc.1.25418.105 -> 10.0.100-rc.1.25419.104) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25418.105 -> 10.0.0-beta.25419.104) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25418.105 -> 0.11.5-alpha.25419.104) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25418.105 -> 2.9.3-beta.25419.104) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-rc.1.25418.105 -> 10.0.0-rc.1.25419.104) NuGet.Frameworks, NuGet.Packaging, NuGet.ProjectModel, NuGet.Versioning (Version 7.0.0-preview.1.41905 -> 7.0.0-preview.1.42004) System.CommandLine (Version 2.0.0-rc.1.25418.105 -> 2.0.0-rc.1.25419.104)

ericstj · 2025-08-20T13:35:10Z

@ViktorHofer analyzer related errors here.

ViktorHofer · 2025-08-20T16:23:03Z

@ericstj this is the package layout:

That should be correct, right?

ericstj · 2025-08-20T17:16:47Z

Error is

/__w/1/s/.dotnet/sdk/10.0.100-rc.1.25411.109/Microsoft.Common.CurrentVersion.targets(2437,5): error MSB3106: Assembly strong name "/__w/1/s/.packages/microsoft.codeanalysis.netanalyzers/10.0.100-rc.1.25419.104/analyzers/dotnet/cs/Microsoft.CodeAnalysis.NetAnalyzers.dll" is either a path which could not be found or it is a full assembly name which is badly formed. If it is a full assembly name it may contain characters that need to be escaped with backslash(\). Those characters are Equals(=), Comma(,), Quote("), Apostrophe('), Backslash(\). [/__w/1/s/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/LibraryImportGenerator.Unit.Tests.csproj]

So it is trying to find Microsoft.CodeAnalysis.NetAnalyzers.dll in the analyzers/dotnet/cs folder. Let's find out why.

ericstj · 2025-08-20T17:19:56Z

Looks like a hardcoded path here -

runtime/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/LibraryImportGenerator.Unit.Tests.csproj

Lines 54 to 58 in 749340b

    
           <Target Name="AddNetAnalyzersAssemblyAsReference" BeforeTargets="ResolveAssemblyReferences" DependsOnTargets="ResolveProjectReferences"> 
        
             <ItemGroup> 
        
               <Reference Include="$(PkgMicrosoft_CodeAnalysis_NetAnalyzers)/analyzers/dotnet/cs/Microsoft.CodeAnalysis.NetAnalyzers.dll" /> 
        
             </ItemGroup> 
        
           </Target>

I'll update that. I think the new package layout from @ViktorHofer's change is more correct. This project voided the warranty by grabbing direct files like this, so it's responsible for the break. cc @jkoritzinsky

jkoritzinsky · 2025-08-20T17:23:30Z

I'm fine with whatever changes need to be made to fix the build.

For reference, we ref this project in this way because we have a diagnostic suppressor for a case where one of the analyzers from there would break SG interop and we didn't want users getting sent down the wrong path.

ericstj · 2025-08-20T17:28:24Z

Yep - it's clear why you did this, only called out responsibility here in case we needed to consider which side should change to fix it. One thing that could make this less fragile would be a package provided for referencing an analyzer, or targets within the analyzer package (which knows its own internal layout) that could raise the reference when a property is set. I'm not sure I'd bother with either since this sort of move/rename is unlikely to happen again.

[[ commit created by automation ]]

Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25419.104 -> 5.0.0-2.25419.113) Microsoft.CodeAnalysis.NetAnalyzers, Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-rc.1.25419.104 -> 10.0.100-rc.1.25419.113) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25419.104 -> 10.0.0-beta.25419.113) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25419.104 -> 0.11.5-alpha.25419.113) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25419.104 -> 2.9.3-beta.25419.113) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-rc.1.25419.104 -> 10.0.0-rc.1.25419.113) NuGet.Frameworks, NuGet.Packaging, NuGet.ProjectModel, NuGet.Versioning (Version 7.0.0-preview.1.42004 -> 7.0.0-preview.1.42013) System.CommandLine (Version 2.0.0-rc.1.25419.104 -> 2.0.0-rc.1.25419.113)

Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25419.113 -> 5.0.0-2.25420.121) Microsoft.CodeAnalysis.NetAnalyzers, Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-rc.1.25419.113 -> 10.0.100-rc.1.25420.121) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25419.113 -> 10.0.0-beta.25420.121) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25419.113 -> 0.11.5-alpha.25420.121) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25419.113 -> 2.9.3-beta.25420.121) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-rc.1.25419.113 -> 10.0.0-rc.1.25420.121) NuGet.Frameworks, NuGet.Packaging, NuGet.ProjectModel, NuGet.Versioning (Version 7.0.0-preview.1.42013 -> 7.0.0-preview.1.42121) System.CommandLine (Version 2.0.0-rc.1.25419.113 -> 2.0.0-rc.1.25420.121)

ericstj · 2025-08-21T15:42:52Z

@dotnet/wasm-eng seems like many wasm tests are failing with the same error here:

[] fail: Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware[1]
[]       An unhandled exception has occurred while executing the request.
[]       System.InvalidOperationException: ETag header not found.
[]          at Microsoft.AspNetCore.Builder.StaticAssetDescriptorExtensions.GetWeakETag(StaticAssetDescriptor descriptor)
[]          at Microsoft.AspNetCore.Builder.StaticAssetDevelopmentRuntimeHandler.AttachRuntimePatching(EndpointBuilder builder)
[]          at Microsoft.AspNetCore.StaticAssets.StaticAssetEndpointFactory.Create(StaticAssetDescriptor resource, List`1 conventions, List`1 finallyConventions)
[]          at Microsoft.AspNetCore.StaticAssets.StaticAssetsEndpointDataSource.UpdateEndpoints()
[]          at Microsoft.AspNetCore.StaticAssets.StaticAssetsEndpointDataSource.Initialize()
[]          at Microsoft.AspNetCore.StaticAssets.StaticAssetsEndpointDataSource.GetChangeToken()
[]          at Microsoft.Extensions.Primitives.ChangeToken.ChangeTokenRegistration`1..ctor(Func`1 changeTokenProducer, Action`1 changeTokenConsumer, TState state)
[]          at Microsoft.Extensions.Primitives.ChangeToken.OnChange(Func`1 changeTokenProducer, Action changeTokenConsumer)
[]          at Microsoft.AspNetCore.Routing.CompositeEndpointDataSource.CreateChangeTokenUnsynchronized(Boolean collectionChanged)
[]          at Microsoft.AspNetCore.Routing.CompositeEndpointDataSource.EnsureChangeTokenInitialized()
[]          at Microsoft.AspNetCore.Routing.CompositeEndpointDataSource.GetChangeToken()
[]          at Microsoft.AspNetCore.Routing.DataSourceDependentCache`1.Initialize()
[]          at System.Threading.LazyInitializer.EnsureInitializedCore[T](T& target, Boolean& initialized, Object& syncLock, Func`1 valueFactory)
[]          at Microsoft.AspNetCore.Routing.Matching.DataSourceDependentMatcher..ctor(EndpointDataSource dataSource, Lifetime lifetime, Func`1 matcherBuilderFactory)
[]          at Microsoft.AspNetCore.Routing.Matching.DfaMatcherFactory.CreateMatcher(EndpointDataSource dataSource)
[]          at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.InitializeCoreAsync()
[]       --- End of stack trace from previous location ---
[]          at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.<Invoke>g__AwaitMatcher|10_0(EndpointRoutingMiddleware middleware, HttpContext httpContext, Task`1 matcherTask)
[]          at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context)

lewing · 2025-08-21T16:20:11Z

@javiercn ptal

pavelsavara · 2025-08-21T16:31:56Z

WBT

cc @maraf @javiercn

Log

ystem.InvalidOperationException: ETag header not found.
[]          at Microsoft.AspNetCore.Builder.StaticAssetDescriptorExtensions.GetWeakETag(StaticAssetDescriptor descriptor)
[]          at Microsoft.AspNetCore.Builder.StaticAssetDevelopmentRuntimeHandler.AttachRuntimePatching(EndpointBuilder builder)
[]          at Microsoft.AspNetCore.StaticAssets.StaticAssetEndpointFactory.Create(StaticAssetDescriptor resource, List`1 conventions, List`1 finallyConventions)
[]          at Microsoft.AspNetCore.StaticAssets.StaticAssetsEndpointDataSource.UpdateEndpoints()
[]          at Microsoft.AspNetCore.StaticAssets.StaticAssetsEndpointDataSource.Initialize()
[]          at Microsoft.AspNetCore.StaticAssets.StaticAssetsEndpointDataSource.GetChangeToken()
[]          at Microsoft.Extensions.Primitives.ChangeToken.ChangeTokenRegistration`1..ctor(Func`1 changeTokenProducer, Action`1 changeTokenConsumer, TState state)
[]          at Microsoft.Extensions.Primitives.ChangeToken.OnChange(Func`1 changeTokenProducer, Action changeTokenConsumer)
[]          at Microsoft.AspNetCore.Routing.CompositeEndpointDataSource.CreateChangeTokenUnsynchronized(Boolean collectionChanged)
[]          at Microsoft.AspNetCore.Routing.CompositeEndpointDataSource.EnsureChangeTokenInitialized()
[]          at Microsoft.AspNetCore.Routing.CompositeEndpointDataSource.GetChangeToken()
[]          at Microsoft.AspNetCore.Routing.DataSourceDependentCache`1.Initialize()
[]          at System.Threading.LazyInitializer.EnsureInitializedCore[T](T& target, Boolean& initialized, Object& syncLock, Func`1 valueFactory)
[]          at Microsoft.AspNetCore.Routing.Matching.DataSourceDependentMatcher..ctor(EndpointDataSource dataSource, Lifetime lifetime, Func`1 matcherBuilderFactory)
[]          at Microsoft.AspNetCore.Routing.Matching.DfaMatcherFactory.CreateMatcher(EndpointDataSource dataSource)
[]          at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.InitializeCoreAsync()
[]       --- End of stack trace from previous location ---
[]          at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.<Invoke>g__AwaitMatcher|10_0(EndpointRoutingMiddleware middleware, HttpContext httpContext, Task`1 matcherTask)
[]          at Microsoft.AspNetCore.Components.WebAssembly.DevServer.Server.Startup.<>c__DisplayClass5_0.<<Configure>b__0>d.MoveNext()
[]       --- End of stack trace from previous location ---
[]          at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context)

ericstj · 2025-08-21T16:37:55Z

I was able to reproduce this by pulling down the test case. I see that the resource has an ETag value but it is not "IsWeak". Any idea what this might mean?

ericstj · 2025-08-21T16:43:50Z

Looks like this data comes from this file --
WasmBasicTestApp.staticwebassets.endpoints.json

ericstj · 2025-08-21T16:55:41Z

I see these are read via https://github.com/dotnet/aspnetcore/blob/30609470fad0bdbe19f14597971542eb4de69641/src/StaticAssets/src/StaticAssetsManifest.cs#L32

I see they are generated with https://github.com/dotnet/sdk/blob/d2466ae2a65b6584444f73d0e1d5f4425ab6c77b/src/StaticWebAssetsSdk/Tasks/GenerateStaticWebAssetEndpointsManifest.cs#L11

@javiercn I suspect your change dotnet/sdk@952f759 caused this

ericstj · 2025-08-21T17:17:17Z

@javiercn I guess this is because you stopped setting weak ETag in Release mode, but these tests are running Release builds.

This component which checks for weak ETag seems to be enabled by the presense of "ManifestType": "Build", in the above file. So maybe that ASP.NET component should stop checking for this - I'm not sure how the runtime side of this is in ASP.NET is supposed to work...

I can see that I can set AttachWeakETagToCompressedAssetsDuringDevelopment in the test's generated project build, so maybe that's what we do for now to workaround this. Let's see if we can find the right place to set this...

javiercn · 2025-08-21T17:33:06Z

@ericstj Yes.

AttachWeakETagToCompressedAssetsDuringDevelopment is precisely available for that reason. In case we need an override. we should just apply it on the affected projects.

javiercn · 2025-08-21T17:33:30Z

@akoeplinger or @maraf can you help with the tests here?

ericstj · 2025-08-21T17:39:35Z

@javiercn I filed dotnet/aspnetcore#63364 because based on what I saw this might impact anyone running dotnet run -c Release on an app with compressed content.

ericstj · 2025-08-21T17:51:03Z

@akoeplinger or @maraf can you help with the tests here?

Would that be to set this property in a place like https://github.com/dotnet/runtime/blob/main/src/mono/wasm/Wasm.Build.Tests/data/Blazor.Directory.Build.props, and other props in the same directory?

javiercn · 2025-08-21T18:14:08Z

I've pushed a change to unblock the build

ericstj · 2025-08-21T18:22:56Z

Are you sure that file isn't going to be overwritten with the props files I pointed out above? I was in the middle of testing a change to the repro and had modified all the props here https://github.com/dotnet/runtime/blob/main/src/mono/wasm/Wasm.Build.Tests/data. It looks to me like these are all copied to test root, (EG: C:\scratch\helix\dotnet-backflo\workitems\Workloads-ST-Wasm.Build.Tests.HttpTests\wbt artifacts\HttpTest_Release_False_4keioy03_gim_鿀蜒枛遫䡫煉\Directory.Build.props) when building the test.

ericstj · 2025-08-21T18:44:45Z

When I tried this in my local repro 56a92b3 did not fix the issue, since those props are not used. The changes I suggested above do fix at least the test case I've been looking at.

This is the copy I was mentioning:

runtime/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs

Lines 83 to 84 in 4b2a7d5

    
           File.Copy(Path.Combine(BuildEnvironment.TestDataPath, "Blazor.Directory.Build.props"), Path.Combine(_projectDir, "Directory.Build.props")); 
        
           File.Copy(Path.Combine(BuildEnvironment.TestDataPath, "Blazor.Directory.Build.targets"), Path.Combine(_projectDir, "Directory.Build.targets"));

runtime/src/mono/wasm/Wasm.Build.Tests/Common/BuildEnvironment.cs

Lines 183 to 187 in 4b2a7d5

    
           protected static string s_directoryBuildPropsForWorkloads = File.ReadAllText(Path.Combine(TestDataPath, "Workloads.Directory.Build.props")); 
        
           protected static string s_directoryBuildTargetsForWorkloads = File.ReadAllText(Path.Combine(TestDataPath, "Workloads.Directory.Build.targets")); 
        
           protected static string s_directoryBuildPropsForLocal = File.ReadAllText(Path.Combine(TestDataPath, "Local.Directory.Build.props")); 
        
           protected static string s_directoryBuildTargetsForLocal = File.ReadAllText(Path.Combine(TestDataPath, "Local.Directory.Build.targets"));

runtime/src/mono/wasm/Wasm.Build.Tests/Common/BuildEnvironment.cs

Lines 94 to 104 in 4b2a7d5

    
           if (workloadInstalled) 
        
           { 
        
               DirectoryBuildPropsContents = s_directoryBuildPropsForWorkloads; 
        
               DirectoryBuildTargetsContents = s_directoryBuildTargetsForWorkloads; 
        
               IsWorkload = true; 
        
           } 
        
           else 
        
           { 
        
               DirectoryBuildPropsContents = s_directoryBuildPropsForLocal; 
        
               DirectoryBuildTargetsContents = s_directoryBuildTargetsForLocal; 
        
           }

runtime/src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs

Lines 241 to 242 in 4b2a7d5

    
           File.WriteAllText(Path.Combine(dir, "Directory.Build.props"), s_buildEnv.DirectoryBuildPropsContents); 
        
           File.WriteAllText(Path.Combine(dir, "Directory.Build.targets"), s_buildEnv.DirectoryBuildTargetsContents);

Maybe we need both? FWIW I also see the same sort of structure under the WASI tests, but maybe those aren't running in this build pipeline. cc @radical

ericstj · 2025-08-21T21:24:45Z

I have temporarily disabled this subscription https://maestro.dot.net/subscriptions?search=f7901f87-9f24-40d6-9bc1-564863937237&showDisabled=True. Will reenable after merging

ericstj · 2025-08-21T23:54:19Z

I have temporarily disabled this subscription

Subscription has been re-enabled.

dotnet-maestro bot added 3 commits August 20, 2025 02:06

Backflow from https://github.com/dotnet/dotnet / 04752cb build 280037

54c4bf4

[[ commit created by automation ]]

Merge main into darc-main-3cf679c9-4176-4196-8552-e49d000d43de

2f31d17

github-actions bot added the area-codeflow for labeling automated codeflow label Aug 20, 2025

This was referenced Aug 20, 2025

[android] Android.Device_Emulator.JIT.Test failing on emulators with CoreCLR #112633

Open

[browser] Wasm.Build.Tests timeout - Timed out after 10s waiting for 'WASM EXIT' #116697

Open

Unable to pull image from mcr.microsoft.com #117164

Open

Update path to Microsoft.CodeAnalysis.NetAnalyzers.dll

a5d624a

ericstj approved these changes Aug 20, 2025

View reviewed changes

ericstj enabled auto-merge (squash) August 20, 2025 17:54

dotnet-maestro bot added 2 commits August 20, 2025 19:49

Backflow from https://github.com/dotnet/dotnet / 4b87d6e build 280132

d88df06

[[ commit created by automation ]]

ericstj mentioned this pull request Aug 20, 2025

Microsoft.DotNet.CoreSetup.Test.HostActivation.DependencyResolution.LocalPath.NativeLibraries_SelfContained fails with error 0x86 (134) on macos #118945

Closed

build-analysis bot mentioned this pull request Aug 21, 2025

System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783

Closed

ericstj mentioned this pull request Aug 21, 2025

ETag header not found error when running release build of app with compressed resources dotnet/aspnetcore#63364

Closed

1 task

Unblock the build

56a92b3

javiercn requested review from ilonatommy and maraf as code owners August 21, 2025 18:11

ericstj mentioned this pull request Aug 21, 2025

Remove AttachWeakETagToCompressedAssetsDuringDevelopment workaround from WASM tests when we have a fix #118967

Closed

Apply AttachWeakETagToCompressedAssetsDuringDevelopment workaround

193904c

build-analysis bot mentioned this pull request Aug 21, 2025

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

2 tasks

ericstj merged commit cda0bf4 into main Aug 21, 2025
167 of 168 checks passed

dotnet-maestro bot deleted the darc-main-3cf679c9-4176-4196-8552-e49d000d43de branch August 21, 2025 23:46

ViktorHofer restored the darc-main-3cf679c9-4176-4196-8552-e49d000d43de branch August 29, 2025 11:09

ViktorHofer deleted the darc-main-3cf679c9-4176-4196-8552-e49d000d43de branch August 29, 2025 11:11

Copilot AI mentioned this pull request Sep 9, 2025

[browser] Remove AttachWeakETagToCompressedAssetsDuringDevelopment workaround from Wasm.Build.Tests #119494

Merged

LoopedBard3 mentioned this pull request Sep 25, 2025

[Perf] Linux/x64: 1 Regression on 7/10/2025 8:38:35 PM +00:00 dotnet/perf-autofiling-issues#59275

Closed

github-actions bot locked and limited conversation to collaborators Sep 29, 2025

[main] Source code updates from dotnet/dotnet #118914

[main] Source code updates from dotnet/dotnet #118914

Uh oh!

Conversation

dotnet-maestro bot commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/dotnet

Associated changes in source repos

Uh oh!

ericstj commented Aug 20, 2025

Uh oh!

ViktorHofer commented Aug 20, 2025

Uh oh!

ericstj commented Aug 20, 2025

Uh oh!

ericstj commented Aug 20, 2025

Uh oh!

jkoritzinsky commented Aug 20, 2025

Uh oh!

ericstj commented Aug 20, 2025

Uh oh!

ericstj commented Aug 21, 2025

Uh oh!

lewing commented Aug 21, 2025

Uh oh!

pavelsavara commented Aug 21, 2025

Uh oh!

ericstj commented Aug 21, 2025

Uh oh!

ericstj commented Aug 21, 2025

Uh oh!

ericstj commented Aug 21, 2025

Uh oh!

ericstj commented Aug 21, 2025

Uh oh!

javiercn commented Aug 21, 2025

Uh oh!

javiercn commented Aug 21, 2025

Uh oh!

ericstj commented Aug 21, 2025

Uh oh!

ericstj commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javiercn commented Aug 21, 2025

Uh oh!

ericstj commented Aug 21, 2025

Uh oh!

ericstj commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericstj commented Aug 21, 2025

Uh oh!

Uh oh!

ericstj commented Aug 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dotnet-maestro bot commented Aug 20, 2025 •

edited

Loading

ericstj commented Aug 21, 2025 •

edited

Loading

ericstj commented Aug 21, 2025 •

edited

Loading