Skip to content

Adding GetAssemblyName cDAC API #118875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2025
Merged

Adding GetAssemblyName cDAC API #118875

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
253a6d3
r
rcj1 Aug 12, 2025
7d606d8
e
rcj1 Aug 13, 2025
7b4248b
adding GetAssemblyName cDAC API
rcj1 Aug 19, 2025
da2cfb1
Merge branch 'main' into GetAssemblyName
rcj1 Aug 19, 2025
f71ed81
codereview
rcj1 Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 47 additions & 1 deletion src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,53 @@ int ISOSDacInterface.GetAssemblyModuleList(ClrDataAddress assembly, uint count,

}
int ISOSDacInterface.GetAssemblyName(ClrDataAddress assembly, uint count, char* name, uint* pNeeded)
=> _legacyImpl is not null ? _legacyImpl.GetAssemblyName(assembly, count, name, pNeeded) : HResults.E_NOTIMPL;
{
int hr = HResults.S_OK;
try
{
if (name is not null)
name[0] = '\0';
Contracts.ILoader contract = _target.Contracts.Loader;
Contracts.ModuleHandle handle = contract.GetModuleHandleFromAssemblyPtr(assembly.ToTargetPointer(_target));
string path = contract.GetPath(handle);

// Return not implemented for empty paths for non-reflection emit assemblies (for example, loaded from memory)
if (string.IsNullOrEmpty(path))
{
Contracts.ModuleFlags flags = contract.GetFlags(handle);
if (!flags.HasFlag(Contracts.ModuleFlags.ReflectionEmit))
hr = HResults.E_NOTIMPL;
else
hr = HResults.E_FAIL;
}

OutputBufferHelpers.CopyStringToBuffer(name, count, pNeeded, path);
}
catch (System.Exception ex)
{
hr = ex.HResult;
}

#if DEBUG
if (_legacyImpl is not null)
{
char[] fileNameLocal = new char[count];
uint neededLocal;
int hrLocal;
fixed (char* ptr = fileNameLocal)
{
hrLocal = _legacyImpl.GetAssemblyName(assembly, count, ptr, &neededLocal);
}
Debug.Assert(hrLocal == hr, $"cDAC: {hr:x}, DAC: {hrLocal:x}");
if (hr == HResults.S_OK)
{
Debug.Assert(pNeeded == null || *pNeeded == neededLocal);
Debug.Assert(name == null || new ReadOnlySpan<char>(fileNameLocal, 0, (int)neededLocal - 1).SequenceEqual(new string(name)));
}
}
#endif
return hr;
}
int ISOSDacInterface.GetCCWData(ClrDataAddress ccw, void* data)
=> _legacyImpl is not null ? _legacyImpl.GetCCWData(ccw, data) : HResults.E_NOTIMPL;
int ISOSDacInterface.GetCCWInterfaces(ClrDataAddress ccw, uint count, void* interfaces, uint* pNeeded)
Expand Down