Remove NativeHostApis multi-level lookup tests
#118796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes multi-level lookup tests for NativeHostApis that are no longer needed. Multi-level lookup was disabled in .NET 7.0 with no option to re-enable for these APIs, making the tests that validate this behavior obsolete.
Key Changes
- Removes multi-level lookup test methods and related test infrastructure
- Simplifies the test fixture by removing global SDK and framework directory setup
- Streamlines the test host application by removing multi-level lookup environment variable handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/installer/tests/HostActivation.Tests/NativeHostApis.cs | Removes multi-level lookup test methods, simplifies SdkAndFrameworkFixture by removing global directory setup, and refactors SDK directory creation |
| src/installer/tests/Assets/Projects/HostApiInvokerApp/Program.cs | Removes multi-level lookup environment variable handling and test behavior path selection logic |
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
AaronRobinsonMSFT
approved these changes
Aug 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized these still existed while doing #118418. Multi-level lookup was disabled in 7.0 with no option to enable for these APIs. These tests validating that it is actually disabled are no longer useful.
cc @dotnet/appmodel @AaronRobinsonMSFT