Skip to content

Restore calls to CreateFatalHandshakeAlertToken on Android #118765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Restore calls to CreateFatalHandshakeAlertToken on Android #118765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/libraries/System.Net.Security/src/System/Net/Security/SslStreamPal.Android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ public static Exception GetException(SecurityStatusPal status)

internal const bool StartMutualAuthAsAnonymous = false;
internal const bool CanEncryptEmptyMessage = false;
internal const bool CanGenerateCustomAlerts = false;

// There is no API to generate custom alerts on Android, but the interop layer currently
// depends on SslStream calling HandshakeInternal one last time when tearing down the connection
// due to handshake failures.
internal const bool CanGenerateCustomAlerts = true;

public static void VerifyPackageInfo()
{
Expand Down Expand Up @@ -231,7 +235,6 @@ public static SecurityStatusPal ApplyAlertToken(
{
// There doesn't seem to be an exposed API for writing an alert.
// The API seems to assume that all alerts are generated internally.
Debug.Assert(CanGenerateCustomAlerts);
return new SecurityStatusPal(SecurityStatusPalErrorCode.OK);
}

Expand Down
Loading