Adding GetClrWatsonBuckets cDAC API

[rcj1]

No description provided.

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull Request Overview

This PR implements the GetClrWatsonBuckets API in the cDAC (Contract-based Data Access Component) system, providing a modern alternative to the legacy DAC implementation. The implementation retrieves Watson bucket data from exception objects for crash reporting and debugging purposes.

Key changes:

• Adds Watson bucket retrieval functionality through Thread and Exception contracts
• Creates new data structures for Object and updates ExceptionInfo to support Watson bucket access
• Implements the complete API with proper error handling and legacy comparison in debug builds

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
SOSDacImpl.cs	Implements the main GetClrWatsonBuckets API with contract-based logic and debug validation
Thread.cs	Adds UEWatsonBucketTrackerBuckets field to Thread data structure
Object.cs	Creates new Object data class with MethodTable property for Watson bucket object access
ExceptionInfo.cs	Adds ExceptionWatsonBucketTrackerBuckets field for exception-specific Watson buckets
Thread_1.cs	Implements three new Thread contract methods for retrieving throwable objects and Watson buckets
Exception_1.cs	Implements GetWatsonBucketsFromThrowable method to extract Watson buckets from exception objects
IThread.cs	Adds interface definitions for the new Thread contract methods
IException.cs	Adds interface definition for GetWatsonBucketsFromThrowable method
threads.h	Defines UEWatsonBucketTrackerBuckets offset in Thread cdac_data structure
exstatecommon.h	Adds friend declarations and includes for cdac_data access
exinfo.h	Defines ExceptionWatsonBucketTrackerBuckets offset in ExInfo cdac_data structure
datadescriptor.inc	Registers new fields in CDAC type system and fixes Object field name
Thread.md	Documents the new Thread contract methods with implementation examples
Exception.md	Documents the new Exception contract method with implementation example

[max-charlamb]

Given this requires some specific size data, I'm wondering if it would make sense to put part of this in the exception or thread contract.

We could discuss more at the meeting tomorrow.

[rcj1]

Given this requires some specific size data, I'm wondering if it would make sense to put part of this in the exception or thread contract.

We could discuss more at the meeting tomorrow.

Sure, we can move this to the thread contract.

[noahfalk]

We should use the Object.GetArrayData() API rather than re-implementing it but otherwise looks good to me.