Skip to content

Adding GetMethodDescFromToken cDAC API #118619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025
Merged

Adding GetMethodDescFromToken cDAC API #118619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4987186
adding GetMethodDescFromToken cDAC API
rcj1 Aug 12, 2025
56fed4a
code review
rcj1 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 59 additions & 1 deletion src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,15 @@ internal sealed unsafe partial class SOSDacImpl
private readonly IXCLRDataProcess2? _legacyProcess2;
private readonly ICLRDataEnumMemoryRegions? _legacyEnumMemory;

private enum CorTokenType: uint
{
mdtTypeRef = 0x01000000,
mdtTypeDef = 0x02000000,
mdtFieldDef = 0x04000000,
mdtMethodDef = 0x06000000,
typeMask = 0xff000000,
}

public SOSDacImpl(Target target, object? legacyObj)
{
_target = target;
Expand Down Expand Up @@ -1042,7 +1051,56 @@ private void CopyNativeCodeVersionToReJitData(
}

int ISOSDacInterface.GetMethodDescFromToken(ClrDataAddress moduleAddr, uint token, ClrDataAddress* methodDesc)
=> _legacyImpl is not null ? _legacyImpl.GetMethodDescFromToken(moduleAddr, token, methodDesc) : HResults.E_NOTIMPL;
{
int hr = HResults.S_OK;
if (moduleAddr == 0 || methodDesc == null)
hr = HResults.E_INVALIDARG;
else
{
try
{
Contracts.ILoader loader = _target.Contracts.Loader;
TargetPointer module = moduleAddr.ToTargetPointer(_target);
Contracts.ModuleHandle moduleHandle = loader.GetModuleHandleFromModulePtr(module);
Contracts.ModuleLookupTables lookupTables = loader.GetLookupTables(moduleHandle);
switch ((CorTokenType)token & CorTokenType.typeMask)
{
case CorTokenType.mdtFieldDef:
*methodDesc = loader.GetModuleLookupMapElement(lookupTables.FieldDefToDesc, token, out var _).ToClrDataAddress(_target);
break;
case CorTokenType.mdtMethodDef:
*methodDesc = loader.GetModuleLookupMapElement(lookupTables.MethodDefToDesc, token, out var _).ToClrDataAddress(_target);
break;
case CorTokenType.mdtTypeDef:
*methodDesc = loader.GetModuleLookupMapElement(lookupTables.TypeDefToMethodTable, token, out var _).ToClrDataAddress(_target);
break;
case CorTokenType.mdtTypeRef:
*methodDesc = loader.GetModuleLookupMapElement(lookupTables.TypeRefToMethodTable, token, out var _).ToClrDataAddress(_target);
break;
default:
hr = HResults.E_INVALIDARG;
break;
}
}
catch (System.Exception ex)
{
hr = ex.HResult;
}
}
#if DEBUG
if (_legacyImpl is not null)
{
ClrDataAddress methodDescLocal;
int hrLocal = _legacyImpl.GetMethodDescFromToken(moduleAddr, token, &methodDescLocal);
Debug.Assert(hrLocal == hr, $"cDAC: {hr:x}, DAC: {hrLocal:x}");
if (hr == HResults.S_OK)
{
Debug.Assert(*methodDesc == methodDescLocal, $"cDAC: {*methodDesc:x}, DAC: {methodDescLocal:x}");
}
}
#endif
return hr;
}
int ISOSDacInterface.GetMethodDescName(ClrDataAddress addr, uint count, char* name, uint* pNeeded)
{
if (addr == 0)
Expand Down
Loading