[mono][arm64] Fix SeqPointInfo allocation #118542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bp_addrs now needs to contain a pointer slot for every single byte in the code.
github-actions
bot
added
the
needs-area-label
BrzVlad
added
area-Debugger-mono
and removed
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a memory allocation bug in the Mono ARM64 runtime's sequence point handling that was introduced by a recent regression. The issue was in the calculation of buffer size for storing breakpoint addresses.
Key Changes:
- Fixed SeqPointInfo allocation size calculation to allocate space for every byte in the code rather than every 4 bytes
|
Tagging subscribers to this area: @thaystg, @dotnet/dotnet-diag |
4 tasks
thaystg
approved these changes
Aug 8, 2025
|
I will add the change in the backport PR. |
|
/ba-g known failures. |
This was referenced Aug 8, 2025
steveisok
pushed a commit
that referenced
this pull request
Sep 4, 2025
…118459) * Fix assertion when stepping * Backport of #118542 --------- Co-authored-by: Thays Grazia <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bp_addrsnow needs to contain a pointer slot for every single byte in the code.Regressed after #118458
Fixes #118519