Fix xUnit1041 in pri1 runtime tests #118412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes xUnit1041 analyzer warnings in priority 1 runtime tests by changing public constructors to private where the constructors are not used outside their containing classes. The xUnit1041 rule flags constructors that appear to be public but are never instantiated externally, suggesting they should be made private to improve encapsulation.
- Changes public constructors to private across 7 test files
- Improves code encapsulation by restricting constructor visibility
- Addresses static analysis warnings without changing test functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| NestedException.cs | Changed NestedException constructor from public to private |
| MultipleException.cs | Changed MultipleException constructor from public to private |
| HandlerException.cs | Changed HandlerException constructor from public to private |
| rethrow.cs | Changed RethrowException constructor from public to private |
| Inline_NewObj.cs | Changed MainApp_Inline constructor from public to private |
| arrres.cs | Changed Test constructor from public to private |
| ClosedStatic.cs | Changed Program constructor from public to private |
github-actions
bot
added
the
needs-area-label
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
added
area-Infrastructure
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
jkotas
approved these changes
Aug 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118409