-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[S390X] Add simd fallback support for unsupported s390x architectures #118376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dotnet/samsung Could you please take a look? These changes may be related to riscv64. |
kasperk81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tab indentation
|
@uweigand can you please review this? |
159b67b to
96e621b
Compare
Vector facility was introduced in the z13, which majorly introduces vector int/short/long/double variants of the vector instructions. with the release of z14 we introduced vector float variant as part of vector enhancement facility 1. This patch majorly supports z13 and previous generations.
96e621b to
97f2fb6
Compare
fix code style Co-authored-by: kasperk81 <[email protected]>
|
Tagging subscribers to this area: @steveisok, @vitek-karas |
* fix test case failures on arm64 * fix more code style reviews
uweigand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the inline comments, you should also fix this:
#define MONO_ARCH_SIMD_INTRINSICS mono_hwcap_s390x_has_vec
and define it to just 1 like everywhere else, since this is not actually evaluated at run-time.
0699ae9 to
5a8180a
Compare
5a8180a to
9f2dad9
Compare
uweigand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version looks good to me now from a s390x target perspective.
|
@akoeplinger can this be merged? |
|
/ba-g failures are unrelated to s390x changes |
|
@akoeplinger can we backport this to release/10.0 as well? |
|
@lewing do we have a policy for changes which only touch community-supported arch code? |
|
@akoeplinger , @lewing - Can we have this backported ? or is there a policy which restricts us from backporting ? |
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17413301220 |
Vector facility was introduced in the z13, which majorly introduces vector int/short/long/double variants of the vector instructions. with the release of z14 we introduced vector float variant and vector max/min as part of vector enhancement facility 1.
with my previous patches #116779, #116669
we have already added support to z14 and above generations.
this patch supports z13 and previous generations