Rename ManagedAssemblyLoadContext to AssemblyLoadContext #118227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR performs a comprehensive rename of ManagedAssemblyLoadContext to AssemblyLoadContext throughout the codebase. The renaming is primarily focused on internal variable names, field names, and parameter names to improve consistency and clarity.
Key Changes:
- Renamed variables and parameters from
ManagedAssemblyLoadContexttoAssemblyLoadContext - Updated struct field names and type names to remove the "Managed" prefix
- Updated comments and documentation to reflect the new naming
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| AssemblyBinder.cs | Renamed property from ManagedAssemblyLoadContext to AssemblyLoadContext |
| Loader_1.cs | Updated usage of renamed property in contract implementation |
| object-internals.h | Renamed enum type from MonoManagedAssemblyLoadContextInternalState to MonoAssemblyLoadContextInternalState |
| loader-internals.h | Updated parameter name in comment documentation |
| AssemblyLoadContext.Mono.cs | Renamed parameter names from gchManagedAssemblyLoadContext to gchAssemblyLoadContext |
| ILLink.Descriptors.xml | Updated comment reference to reflect renamed type |
| AssemblyLoadContext.cs | Updated comments and parameter names to use new naming convention |
| nativelibrary.cpp | Renamed variable and function names from ManagedAssemblyLoadContext to AssemblyLoadContext |
| loaderallocator.hpp | Renamed virtual method from ReleaseManagedAssemblyLoadContext to ReleaseAssemblyLoadContext |
| loaderallocator.cpp | Updated method implementation and call sites to use new name |
| assemblynative.hpp | Renamed parameter in function declaration |
| assemblynative.cpp | Updated parameter names and variable names throughout function implementations |
| assemblybinder.h | Renamed member field and associated getter/setter methods |
| assemblybinder.cpp | Updated method calls to use renamed methods |
| appdomain.cpp | Renamed parameter and variable names in function implementations |
| datadescriptor.inc | Updated field name in data descriptor |
| request.cpp | Renamed variable names in DAC request handling |
| assemblybindercommon.hpp | Updated parameter name in function declaration |
| defaultassemblybinder.cpp | Renamed variable names in binding logic |
| customassemblybinder.cpp | Updated method calls and variable names |
| assemblybindercommon.cpp | Renamed parameter names in function implementations |
| AssemblyLoadContext.CoreCLR.cs | Updated parameter names in VM callback methods |
dotnet-policy-service
bot
added
the
linkable-framework
|
Context #117939 (review) |
jkotas
removed
the
linkable-framework
dotnet-policy-service
bot
added
the
linkable-framework
rcj1
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
LGTM except for
runtime/docs/design/datacontracts/Loader.md
Line 112 in ac764af
This was referenced Jul 31, 2025
|
/ba-g wasm timeouts with no logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no unmanaged assembly load context, so the "Managed" prefix is superfluous.