[Android][CoreCLR] Add runtimeconfig.json support for test host #117980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd values by replacing the template placeholders
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR implements runtime configuration support for the Android CoreCLR test host by parsing runtimeconfig.json files and applying the configuration through AppContext keys/values. The change replaces the previous approach of setting environment variables with a more robust template-based system that dynamically generates C code with the appropriate runtime configuration.
Key changes:
- Replaced hardcoded AppContext properties with template placeholders in the CoreCLR C template
- Added JSON parsing logic to extract runtime configuration properties and generate corresponding C code
- Removed redundant environment variable settings from the Android build configuration
- Re-enabled previously failing tests that now pass with proper runtime configuration support
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/tasks/AndroidAppBuilder/Templates/monodroid-coreclr.c |
Converted hardcoded AppContext arrays to template placeholders for dynamic generation |
src/tasks/AndroidAppBuilder/ApkBuilder.cs |
Added JSON parsing and template replacement logic to process runtimeconfig.json |
src/mono/msbuild/android/build/AndroidBuild.props |
Removed obsolete environment variable definitions for runtime switches |
src/libraries/tests.proj |
Re-enabled three test projects that now pass with proper runtime config support |
src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/DisabledFileLockingTests/DisabledFileLockingSwitchTests.cs |
Removed ActiveIssue attribute from a test that now works |
davidnguyen-tech
added
area-Infrastructure-coreclr
os-android
and removed
needs-area-label
|
Tagging subscribers to this area: @hoyosjs |
|
/azp run runtime-android,runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
akoeplinger
approved these changes
Jul 23, 2025
vitek-karas
approved these changes
Jul 23, 2025
|
/azp run runtime-android,runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-android,runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Jul 24, 2025
18 tasks
|
/azp run runtime-android,runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Jul 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we add support for ALL runtime configuration options for the CoreCLR Android test host by doing the following:
runtimeconfig.json.monodroid-coreclr.ctemplate.Why it works
[appname].runtimeconfig.jsonfile when building the app.jsongeneration works properlyChanges
monodroid-coreclr.ctemplateApkBuilder.cs, when rendering themonodroid-coreclr.ctemplate, we parseruntimeconfig.jsonand apply it by replacing the template placeholders to set actual AppContext keys and valuesAndroidBuild.props(became redundant)Newly non-failing tests with execution results
System.Runtime.InvariantTimezone.Tests.csprojSystem.Diagnostics.DiagnosticSource.Switches.Tests.csprojSystem.IO.FileSystem.DisabledFileLocking.Tests.csprojSystem.Text.Encoding.Tests.csprojRelated issues
System.Runtime.InvariantTimezone.Tests.csprojfails on CoreCLR Android #117658