-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add support for Android RIDs to NativeAOT #117953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…er flavor that fixes issues in the java toolchain (pulling from the dotnet/android targets)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Android Runtime Identifiers (RIDs) to NativeAOT compilation by treating Android as a Linux variant in the NativeAOT toolchain. The changes enable Android applications to be compiled using NativeAOT, which provides ahead-of-time compilation benefits for mobile platforms.
Key changes:
- Configures NativeAOT compiler to treat Android as Linux for compilation purposes
- Sets up Android-specific linker and cryptography library configurations
- Updates build system to recognize Android as a supported NativeAOT target platform
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
Microsoft.NETCore.Native.targets | Maps Android target OS to Linux for NativeAOT compiler |
Microsoft.NETCore.Native.Unix.targets | Configures Android-specific linker and crypto libraries |
eng/Subsets.props | Adds Android to supported NativeAOT platforms and build subsets |
@dotnet/samsung Could you please take a look? These changes may be related to riscv64. |
Co-authored-by: Copilot <[email protected]>
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
Co-authored-by: Michal Strehovský <[email protected]>
Co-authored-by: Adeel Mujahid <[email protected]>
/ba-g wasm failures unrelated |
dotnet/dotnet#1573 validates the changes that actually modify the build. The targets changes are based on https://github.com/dotnet/android/blob/8f5f54e79d01f7d8a98dc0a1f8ef5e77bc45f52f/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.NativeAOT.targets