-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Revert "Show specific error message for dotnet <app_path>
where app_path is a non-dll/exe file that exists"
#117937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…_path is…" This reverts commit 9d6caae.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts a previous change that added specific error messaging for when users run dotnet <app_path>
where the app_path is an existing non-dll/exe file. The revert removes the special case handling and returns to the original behavior where such cases are routed to the CLI instead of showing a specific error.
- Removes the special case detection for non-managed files with directory separators
- Reverts error message back to the generic "does not exist or is not a managed .dll or .exe" message
- Removes associated test cases that verified the specific error behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/native/corehost/fxr/command_line.cpp | Removes the logic that detects existing non-managed files with directory separators and shows specific error messages |
src/installer/tests/HostActivation.Tests/FrameworkDependentAppLaunch.cs | Updates test assertion to expect the generic error message instead of the specific one |
src/installer/tests/HostActivation.Tests/DotnetArgValidation.cs | Removes two test methods that verified the specific error behavior for non-managed files |
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sounds like this should be an SDK feature instead.
/backport to release/10.0-preview7 |
Started backporting to release/10.0-preview7: https://github.com/dotnet/runtime/actions/runs/16528196413 |
Reverts #116940
See #116940 (comment)