Skip to content

Conversation

elinor-fung
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings July 22, 2025 16:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous change that added specific error messaging for when users run dotnet <app_path> where the app_path is an existing non-dll/exe file. The revert removes the special case handling and returns to the original behavior where such cases are routed to the CLI instead of showing a specific error.

  • Removes the special case detection for non-managed files with directory separators
  • Reverts error message back to the generic "does not exist or is not a managed .dll or .exe" message
  • Removes associated test cases that verified the specific error behavior

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/native/corehost/fxr/command_line.cpp Removes the logic that detects existing non-managed files with directory separators and shows specific error messages
src/installer/tests/HostActivation.Tests/FrameworkDependentAppLaunch.cs Updates test assertion to expect the generic error message instead of the specific one
src/installer/tests/HostActivation.Tests/DotnetArgValidation.cs Removes two test methods that verified the specific error behavior for non-managed files

Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sounds like this should be an SDK feature instead.

@jjonescz
Copy link
Member

/backport to release/10.0-preview7

Copy link
Contributor

Started backporting to release/10.0-preview7: https://github.com/dotnet/runtime/actions/runs/16528196413

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants