Skip to content

Conversation

jonathandavies-arm
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 22, 2025
@jonathandavies-arm
Copy link
Contributor Author

@dotnet/arm64-contrib @amanasifkhalid

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, just need to fix the test generator file

Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

superpmi-replay is failing with "method is of low integrity" errors. I believe that indicates corruption in the collection (#74596), though I don't see why that wasn't noticed before this PR. There's a superpmi-collect run in-progress at the moment; I'm going to wait for that to finish before I merge this under the assumption that the new collections will be sound, so we don't regress superpmi-replay runs.

@amanasifkhalid
Copy link
Contributor

/ba-g infra failures (scripts don't have exec permissions)

@amanasifkhalid amanasifkhalid merged commit 22a2c4d into dotnet:main Jul 24, 2025
154 of 164 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants