Skip to content

Conversation

vcsjones
Copy link
Member

This adds an Experimental implementation of SLH-DSA backed by CNG that, for now, only throws PNSE. This will ensure we get the API surface shipped so that the implementation can be filled in later.

@Copilot Copilot AI review requested due to automatic review settings July 21, 2025 17:11
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a stub implementation of the Stateless Hash-based Digital Signature Algorithm (SLH-DSA) backed by CNG to establish the API surface for future implementation. The changes introduce experimental SLH-DSA algorithm identifiers and a CNG-based class that currently throws PlatformNotSupportedException for all operations.

  • Adds SLH-DSA algorithm identifiers to CNG classes with experimental attributes
  • Creates SlhDsaCng class with complete API surface but stub implementations
  • Updates project files to include the new SlhDsaCng implementation

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
CngAlgorithmGroup.cs Adds SlhDsa algorithm group property with experimental attribute
CngAlgorithm.cs Adds SlhDsa algorithm property with experimental attribute
System.Security.Cryptography.csproj Includes SlhDsaCng.cs in compilation
System.Security.Cryptography.cs Adds SlhDsaCng class to reference assembly
Microsoft.Bcl.Cryptography.csproj Includes SlhDsaCng.cs in BCL project
SlhDsaCng.cs Implements stub SlhDsaCng class with PNSE-throwing methods

@PranavSenthilnathan
Copy link
Member

/ba-g known timeout issues and wasm failures

@PranavSenthilnathan PranavSenthilnathan merged commit c6bf4d5 into dotnet:main Jul 23, 2025
81 of 87 checks passed
@vcsjones vcsjones deleted the slhdsacng branch July 23, 2025 10:21
@vcsjones vcsjones added this to the 10.0.0 milestone Jul 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants