-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add stub implementation of SlhDsaCng and algorithm identifiers #117889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a stub implementation of the Stateless Hash-based Digital Signature Algorithm (SLH-DSA) backed by CNG to establish the API surface for future implementation. The changes introduce experimental SLH-DSA algorithm identifiers and a CNG-based class that currently throws PlatformNotSupportedException for all operations.
- Adds SLH-DSA algorithm identifiers to CNG classes with experimental attributes
- Creates SlhDsaCng class with complete API surface but stub implementations
- Updates project files to include the new SlhDsaCng implementation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
File | Description |
---|---|
CngAlgorithmGroup.cs | Adds SlhDsa algorithm group property with experimental attribute |
CngAlgorithm.cs | Adds SlhDsa algorithm property with experimental attribute |
System.Security.Cryptography.csproj | Includes SlhDsaCng.cs in compilation |
System.Security.Cryptography.cs | Adds SlhDsaCng class to reference assembly |
Microsoft.Bcl.Cryptography.csproj | Includes SlhDsaCng.cs in BCL project |
SlhDsaCng.cs | Implements stub SlhDsaCng class with PNSE-throwing methods |
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/SlhDsaCng.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithm.cs
Outdated
Show resolved
Hide resolved
/ba-g known timeout issues and wasm failures |
This adds an
Experimental
implementation of SLH-DSA backed by CNG that, for now, only throws PNSE. This will ensure we get the API surface shipped so that the implementation can be filled in later.