-
Notifications
You must be signed in to change notification settings - Fork 5.2k
JIT: Handle byref<->nint casts on addresses in local morph #117885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issue #99759 by adding proper handling of byref-to-nint and nint-to-byref casts on addresses during local morphing in the JIT compiler. The change ensures that cast operations between these pointer-like types are correctly processed in the LocalAddressVisitor without causing addresses to escape unnecessarily.
Key changes:
- Added GT_CAST case handling in LocalAddressVisitor to process byref<->nint casts on addresses
- Minor comment formatting fix in importer.cpp
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/coreclr/jit/lclmorph.cpp | Added GT_CAST case to handle byref<->nint casts on addresses in LocalAddressVisitor |
src/coreclr/jit/importer.cpp | Fixed comment formatting by adding missing "//" |
Fix #99759