Fix issues with rejit profiler test

[kg]

• Include the name of the current method in the replacement strings inserted by the custom profiler
• Capture and validate the stdout messages in the test so we can check whether the rejit revert actually worked
• Fix failure when running r2r composite version of test on some configurations (it expected inlining to happen, but there's no guarantee it will)
• Fix a small oversight in rejit.cpp

[kg]

/azp run runtime-coreclr crossgen2 outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kg]

/azp run runtime-coreclr crossgen2 outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kg]

OK, reverts being broken aside I think what's going on is that on the composite R2R side, rejitting the method sometimes doesn't rejit any of its callers, which means no inlining happens and the profiler test breaks (it expects to see inlining). I think the R2R composite behavior is correct based on the output, and revert actually works correctly:

Profilee STDOUT: TriggerDirectInlining
Profilee STDOUT: Hello from profiler rejit method 'InlineeTarget'!  (TriggerDirectInlining)
Profilee STDOUT: CallMethodWithoutInlining
Profilee STDOUT: Hello from profiler rejit method 'InlineeTarget'!  (CallMethodWithoutInlining)
Profilee STDOUT: TriggerInliningChain
Profilee STDOUT:  Inline.InlineeChain1
Profilee STDOUT: Hello from profiler rejit method 'InlineeTarget'!  (InlineeChain1)

Profilee STDOUT: Revert should be triggered after this method...
Profilee STDOUT: TriggerDirectInlining
Profilee STDOUT:   Inline.InlineeTarget (TriggerDirectInlining)
Profilee STDOUT: CallMethodWithoutInlining
Profilee STDOUT:   Inline.InlineeTarget (CallMethodWithoutInlining)
Profilee STDOUT: TriggerInliningChain
Profilee STDOUT:  Inline.InlineeChain1
Profilee STDOUT:   Inline.InlineeTarget (InlineeChain1)

[kg]

@noahfalk if you get a chance, can you tell me whether the rejit.cpp change is correct? It looked like currently we might erroneously skip doing a revert.

[kg]

/azp run runtime-coreclr crossgen2 outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[noahfalk]

Thanks @kg!

[Copilot]

Pull Request Overview

This PR fixes several issues with the rejit profiler test to make it more reliable and properly validate rejit functionality. The changes address test flakiness in R2R composite configurations and improve validation by capturing stdout output.

• Enhances test validation by capturing and checking stdout messages to verify rejit and revert operations
• Improves profiler reliability by filtering out non-test module inlinings and including method names in replacement strings
• Fixes a parameter mismatch in the CoreCLR rejit implementation and temporarily re-enables the test

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/tests/profiler/rejit/rejit.cs	Adds output capturing mechanism and validation logic for rejit/revert operations
src/tests/profiler/native/rejitprofiler/rejitprofiler.cpp	Includes method names in profiler messages and filters inlinings to test module only
src/tests/issues.targets	Temporarily re-enables the rejit test for validation
src/coreclr/vm/rejit.h	Removes unused fIsRevert parameter from method signature
src/coreclr/vm/rejit.cpp	Fixes parameter passing by removing unused fIsRevert parameter