Skip to content

Conversation

@mangod9
Copy link
Member

@mangod9 mangod9 commented Jul 18, 2025

Fixes #106241

Copilot AI review requested due to automatic review settings July 18, 2025 17:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables GC stress testing for Assembly Load Context (ALC) related profiler tests by removing temporary disabling flags that were previously added due to a runtime issue.

  • Removes GCStressIncompatible property from two profiler test projects
  • Re-enables stress testing capabilities that were temporarily disabled
  • Addresses resolution of the underlying issue referenced in GitHub issue #106241

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/tests/profiler/dynamicoptimization/DynamicOptimization.csproj Removes GCStressIncompatible flag and associated comment to re-enable GC stress testing
src/tests/profiler/assembly/ALCTest.csproj Removes GCStressIncompatible flag and associated comment to re-enable GC stress testing

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 18, 2025
@mangod9
Copy link
Member Author

mangod9 commented Jul 18, 2025

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mangod9 mangod9 requested a review from mdh1418 July 22, 2025 16:21
@mangod9
Copy link
Member Author

mangod9 commented Jul 22, 2025

Enabled another profile test which was disabled due to #106241. The test has passed on a few platforms so would be good to see if the issue repros again.

@mangod9
Copy link
Member Author

mangod9 commented Jul 25, 2025

@mdh1418, is this ok to enable?

Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. That said, I dont think this test has ran with GC Stress before since it looks like it was added with that property.

@mangod9 mangod9 merged commit f7ef150 into dotnet:main Jul 30, 2025
89 of 92 checks passed
@mangod9 mangod9 deleted the enable_alc_stress branch July 30, 2025 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: profiler\\assembly\\ALCTest\\ALCTest.cmd

2 participants