Skip to content

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Jul 17, 2025

Description

This PR removes FEATURE_SIMD condition used in callstubgenerator.cpp for CORINFO_HFA_ELEM_VECTOR64 and CORINFO_HFA_ELEM_VECTOR128 return types.

This change should enable 11 methods on the startup path.

Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

@kg
Copy link
Member

kg commented Jul 17, 2025

Is this necessary for startup to work?

@kg
Copy link
Member

kg commented Jul 17, 2025

LGTM but I'm not a build expert

@jkotas
Copy link
Member

jkotas commented Jul 17, 2025

Do you expect that there will be more uses FEATURE_SIMD uses in the VM?

If it is just about the one use in

#ifdef FEATURE_SIMD
, I think it can be deleted instead. I do not expect we would ever want to support building Arm64 without SIMD support in the calling convention.

@kotlarmilos
Copy link
Member Author

I don't expect that there will be more FEATURE_SIMD uses in the VM. Removed as suggested.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants