JIT: Fix unique successors in BBswtDesc in async
#117759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
jakobbotsch
requested review from
amanasifkhalid
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the order of the cases and succs parameters when constructing the BBswtDesc in the async transformation, ensuring the unique successor count aligns with the proper argument.
- Swaps the
casesandsuccsarguments to match the expected constructor signature - Adds an inline
/* hasDefault */comment for the boolean parameter - Reformats the
new BBswtDescinvocation onto two lines
Comments suppressed due to low confidence (1)
src/coreclr/jit/async.cpp:2308
- [nitpick] For readability, consider formatting the
new BBswtDescinvocation with one argument per line and aligned indentation so it's clear which values correspond to each parameter.
BBswtDesc* const swtDesc = new (m_comp, CMK_BasicBlock)
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
amanasifkhalid
approved these changes
Jul 17, 2025
Open
3 tasks
|
/ba-g Infra timeouts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cases and successors were swapped in #117423.